Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 935553002: bindings: Fixes push_messaging/interfaces.html test. (Closed)

Created:
5 years, 10 months ago by Yuki
Modified:
5 years, 10 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Fixes push_messaging/interfaces.html test. Fixes http/tests/push_messaging/interfaces.html test to use assert_will_be_idl_attribute. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
Could you guys review this CL?
5 years, 10 months ago (2015-02-17 09:49:52 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-17 10:54:33 UTC) #3
jsbell
lgtm
5 years, 10 months ago (2015-02-17 18:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935553002/1
5 years, 10 months ago (2015-02-17 18:20:23 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:29:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190345

Powered by Google App Engine
This is Rietveld 408576698