App launcher: Spoken feedback reads out details of search results.

App launcher: Spoken feedback reads out details of search results.

This means the grey text under the title, which usually explains what
type the result is (e.g., "Google Search" or "Chrome Web Store").

BUG=450644
Committed: https://crrev.com/3fd8c986bd999d5f368d4296bdc8715af05fbc49
Cr-Commit-Position: refs/heads/master@{#316953}

[Matt Giuca, 2015-02-17 07:54:42]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2015-02-17 07:54:43]

https://codereview.chromium.org/935523002/diff/1/ui/app_list/views/search_res...
File ui/app_list/views/search_result_view.h (right):

https://codereview.chromium.org/935523002/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_view.h:41: class APP_LIST_EXPORT
SearchResultView
This is needed for tests.

https://codereview.chromium.org/935523002/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_view.h:65: base::string16
ComputeAccessibleName() const;
This is also needed for tests.

Unfortunately, we cannot call Button::GetAccessibleName, because there is no
such thing. And we cannot call Button::GetAccessibleState, because it requires a
ui::AXViewState, and its constructor is in a separate DLL which is not linked
into the tests! Aarrghh!

So I just provide this separate method for tests to find out what the accessible
name will be.

[calamity, 2015-02-18 03:57:33]

lgtm

https://codereview.chromium.org/935523002/diff/1/ui/app_list/views/search_res...
File ui/app_list/views/search_result_view.h (right):

https://codereview.chromium.org/935523002/diff/1/ui/app_list/views/search_res...
ui/app_list/views/search_result_view.h:65: base::string16
ComputeAccessibleName() const;
On 2015/02/17 07:54:43, Matt Giuca wrote:
> This is also needed for tests.
> 
> Unfortunately, we cannot call Button::GetAccessibleName, because there is no
> such thing. And we cannot call Button::GetAccessibleState, because it requires
a
> ui::AXViewState, and its constructor is in a separate DLL which is not linked
> into the tests! Aarrghh!
> 
> So I just provide this separate method for tests to find out what the
accessible
> name will be.

lol.

[Matt Giuca, 2015-02-18 03:57:54]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-18 03:58:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935523002/1

[commit-bot: I haz the power, 2015-02-18 04:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 04:28:57]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Matt Giuca, 2015-02-18 08:16:53]

New patchsets have been uploaded after l-g-t-m from calamity@chromium.org

[Matt Giuca, 2015-02-18 08:18:36]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-18 08:19:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935523002/20001

[commit-bot: I haz the power, 2015-02-18 09:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 09:53:40]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Matt Giuca, 2015-02-18 23:51:14]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935523002/40001

[commit-bot: I haz the power, 2015-02-19 01:25:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-19 01:26:15]

Patchset 3 (id:??) landed as
https://crrev.com/3fd8c986bd999d5f368d4296bdc8715af05fbc49
Cr-Commit-Position: refs/heads/master@{#316953}