Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: ui/app_list/views/search_result_view.h

Issue 935523002: App launcher: Spoken feedback reads out details of search results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NON_EXPORTED_BASE to fix Windows compile. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/views/search_result_list_view_unittest.cc ('k') | ui/app_list/views/search_result_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/search_result_view.h
diff --git a/ui/app_list/views/search_result_view.h b/ui/app_list/views/search_result_view.h
index 10ec425b51037a4025351fb1d95decea98d738fc..279a2a3e1c9926b0dc9180f5e1e906a94b178b5a 100644
--- a/ui/app_list/views/search_result_view.h
+++ b/ui/app_list/views/search_result_view.h
@@ -9,7 +9,9 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
+#include "base/strings/string16.h"
#include "ui/app_list/search_result_observer.h"
#include "ui/app_list/views/search_result_actions_view_delegate.h"
#include "ui/views/context_menu_controller.h"
@@ -37,11 +39,12 @@ class SearchResultViewDelegate;
class SearchResultActionsView;
// SearchResultView displays a SearchResult.
-class SearchResultView : public views::CustomButton,
- public views::ButtonListener,
- public views::ContextMenuController,
- public SearchResultObserver,
- public SearchResultActionsViewDelegate {
+class APP_LIST_EXPORT SearchResultView
+ : public views::CustomButton,
+ public views::ButtonListener,
+ public views::ContextMenuController,
+ public SearchResultObserver,
+ NON_EXPORTED_BASE(public SearchResultActionsViewDelegate) {
public:
// Internal class name.
static const char kViewClassName[];
@@ -59,6 +62,9 @@ class SearchResultView : public views::CustomButton,
// Clears the selected action.
void ClearSelectedAction();
+ // Computes the button's spoken feedback name.
+ base::string16 ComputeAccessibleName() const;
+
void set_is_last_result(bool is_last) { is_last_result_ = is_last; }
private:
@@ -66,6 +72,7 @@ class SearchResultView : public views::CustomButton,
void UpdateTitleText();
void UpdateDetailsText();
+ void UpdateAccessibleName();
// views::View overrides:
const char* GetClassName() const override;
« no previous file with comments | « ui/app_list/views/search_result_list_view_unittest.cc ('k') | ui/app_list/views/search_result_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698