Separate OnJNIOnLoad

android_webview/lib/main/webview_entry_point.cc

Index: android_webview/lib/main/webview_entry_point.cc
diff --git a/android_webview/lib/main/webview_entry_point.cc b/android_webview/lib/main/webview_entry_point.cc
index 7de575a6e1c8ab6ca99e18726c6dcfc0937537e8..44135b74fc5d34dae481769d2382691f5db04531 100644
--- a/android_webview/lib/main/webview_entry_point.cc
+++ b/android_webview/lib/main/webview_entry_point.cc
@@ -2,14 +2,17 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "android_webview/lib/main/webview_jni_onload_delegate.h"
+#include "android_webview/lib/main/webview_jni_onload.h"

[jam, 2015/02/20 06:37:37]

nit: why not just inline these two methods in this file and get rid of that
header and cc file?

[michaelbai, 2015/02/20 17:00:17]

These methods will be used by the monochrome's JNI_OnLoad() method.

[michaelbai, 2015/02/20 17:06:15]

or I will have android_webview::OnJNIOnLoadInit(), might refactorying this part
in monochrome's CL.

[Torne, 2015/02/20 18:24:10]

Yeah, we will almost certainly need to reuse these methods in the monochrome
entry point as Michael says. It's better for us if this file contains nothing
but JNI_OnLoad doing as little as possible by calling other functions.

 #include "base/android/jni_android.h"
+#include "base/bind.h"
 #include "content/public/app/content_jni_onload.h"
 
 // This is called by the VM when the shared library is first loaded.
 // Most of the initialization is done in LibraryLoadedOnMainThread(), not here.
 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
-  if (!android_webview::OnJNIOnLoad(vm))
+  if (!content::android::OnJNIOnLoadRegisterJNI(
+          vm, base::Bind(&android_webview::RegisterJNI)) ||
+      !content::android::OnJNIOnLoadInit(base::Bind(&android_webview::Init)))
     return -1;
 
   return JNI_VERSION_1_4;