Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: android_webview/lib/main/webview_entry_point.cc

Issue 935413004: Separate OnJNIOnLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/android_webview.gyp ('k') | android_webview/lib/main/webview_jni_onload.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/lib/main/webview_jni_onload_delegate.h" 5 #include "android_webview/lib/main/webview_jni_onload.h"
jam 2015/02/20 06:37:37 nit: why not just inline these two methods in this
michaelbai 2015/02/20 17:00:17 These methods will be used by the monochrome's JNI
michaelbai 2015/02/20 17:06:15 or I will have android_webview::OnJNIOnLoadInit(),
Torne 2015/02/20 18:24:10 Yeah, we will almost certainly need to reuse these
6 #include "base/android/jni_android.h" 6 #include "base/android/jni_android.h"
7 #include "base/bind.h"
7 #include "content/public/app/content_jni_onload.h" 8 #include "content/public/app/content_jni_onload.h"
8 9
9 // This is called by the VM when the shared library is first loaded. 10 // This is called by the VM when the shared library is first loaded.
10 // Most of the initialization is done in LibraryLoadedOnMainThread(), not here. 11 // Most of the initialization is done in LibraryLoadedOnMainThread(), not here.
11 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 12 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
12 if (!android_webview::OnJNIOnLoad(vm)) 13 if (!content::android::OnJNIOnLoadRegisterJNI(
14 vm, base::Bind(&android_webview::RegisterJNI)) ||
15 !content::android::OnJNIOnLoadInit(base::Bind(&android_webview::Init)))
13 return -1; 16 return -1;
14 17
15 return JNI_VERSION_1_4; 18 return JNI_VERSION_1_4;
16 } 19 }
OLDNEW
« no previous file with comments | « android_webview/android_webview.gyp ('k') | android_webview/lib/main/webview_jni_onload.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698