device/bluetooth/bluetooth_socket_chromeos.h - Issue 935383003: Fix BluetoothAdapterProfileChromeOS lifecycle management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_socket_chromeos.h

Issue 935383003: Fix BluetoothAdapterProfileChromeOS lifecycle management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add DCHECK confirming profiles are gone during shutdown Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_adapter_chromeos.cc ('K') | « device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc ('k') | device/bluetooth/bluetooth_socket_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_socket_chromeos.h

diff --git a/device/bluetooth/bluetooth_socket_chromeos.h b/device/bluetooth/bluetooth_socket_chromeos.h

index caa0c7150afbee7ed26da35ecaca90dc66c92728..b2be9aa7d1bc1ca27b22b6d89f988ec7d8ac5dd5 100644

--- a/device/bluetooth/bluetooth_socket_chromeos.h

+++ b/device/bluetooth/bluetooth_socket_chromeos.h

@@ -148,12 +148,9 @@ class CHROMEOS_EXPORT BluetoothSocketChromeOS

// Method run to clean-up a listening socket.

void DoCloseListening();

- // Unregister the underlying profile client object from the Bluetooth Daemon.

+ // Unregister use of the profile.

armansito 2015/02/24 23:32:51 Maybe elaborate more? What does it mean to unregis

Marie Janssen 2015/02/27 18:56:58 Done.

void UnregisterProfile();

- // Releases the profile after the delegate is gone.

- void ReleaseProfile(BluetoothAdapterProfileChromeOS* profile);

// Adapter the profile is registered against

scoped_refptr<device::BluetoothAdapter> adapter_;