device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc - Issue 935383003: Fix BluetoothAdapterProfileChromeOS lifecycle management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc

Issue 935383003: Fix BluetoothAdapterProfileChromeOS lifecycle management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add DCHECK confirming profiles are gone during shutdown Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_adapter_chromeos.cc ('K') | « device/bluetooth/bluetooth_adapter_profile_chromeos.cc ('k') | device/bluetooth/bluetooth_socket_chromeos.h » ('j') | device/bluetooth/bluetooth_socket_chromeos.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc

diff --git a/device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc b/device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc

index 6b29dd241c0b53fe1354d14ff21489bc5fd279ef..3176b8eee9f289a4f1a08e4dcaf21255e944dff3 100644

--- a/device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc

+++ b/device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc

@@ -151,8 +151,8 @@ TEST_F(BluetoothAdapterProfileChromeOSTest, DelegateCount) {

options.require_authentication.reset(new bool(false));

profile_ = BluetoothAdapterProfileChromeOS::Register(

- static_cast<BluetoothAdapterChromeOS*>(adapter_.get()), uuid, options,

- base::Bind(&base::DoNothing), base::Bind(&DoNothingDBusErrorCallback));

+ uuid, options, base::Bind(&base::DoNothing),

+ base::Bind(&DoNothingDBusErrorCallback));

message_loop_.RunUntilIdle();

@@ -185,7 +185,7 @@ TEST_F(BluetoothAdapterProfileChromeOSTest, BlackHole) {

options.require_authentication.reset(new bool(false));

profile_ = BluetoothAdapterProfileChromeOS::Register(

- static_cast<BluetoothAdapterChromeOS*>(adapter_.get()), uuid, options,

+ uuid, options,

base::Bind(

&BluetoothAdapterProfileChromeOSTest::DBusConnectSuccessCallback,

base::Unretained(this)),

@@ -224,7 +224,7 @@ TEST_F(BluetoothAdapterProfileChromeOSTest, Routing) {

options.require_authentication.reset(new bool(false));

profile_ = BluetoothAdapterProfileChromeOS::Register(

- static_cast<BluetoothAdapterChromeOS*>(adapter_.get()), uuid, options,

+ uuid, options,

base::Bind(

&BluetoothAdapterProfileChromeOSTest::DBusConnectSuccessCallback,

base::Unretained(this)),