Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 935283002: Rename {Author,UserAgent}ShadowRoot to {Open,Closed}ShadowRoot. (Closed)

Created:
5 years, 10 months ago by hayato
Modified:
5 years, 10 months ago
Reviewers:
tkent, dglazkov, kochi
CC:
blink-reviews, nektarios, je_julie(Not used), kouhei+svg_chromium.org, vivekg_samsung, webcomponents-bugzilla_chromium.org, eae+blinkwatch, fs, eric.carlson_apple.com, vivekg, nessy, apavlov+blink_chromium.org, aandrey+blink_chromium.org, Stephen Chennney, rwlbuis, caseq+blink_chromium.org, krit, arv+blink, aboxhall, blink-reviews-events_chromium.org, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr+svgwatchlist_chromium.org, philipj_slow, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, Dominik Röttsches, eustas+blink_chromium.org, dmazzoni, gyuyoung.kim_webkit.org, darktears, dcheng, vcarbune.chromium, blink-reviews-rendering, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename {Author,UserAgent}ShadowRoot to {Open,Closed}ShadowRoot. This batch-renaming is the very first step to support a closed shadow tree. No functional changes at all. The relevant W3C spec issues: - [Shadow]: Define the behavior of *closed* shadow trees https://www.w3.org/Bugs/Public/show_bug.cgi?id=27775 - [Shadow]: Add "closed" flag to createShadowRoot https://www.w3.org/Bugs/Public/show_bug.cgi?id=20144 See the bug 459136 for the details of the motivation. The file names of existing layout tests aren't touched at all in this CL so that we can isolate an issue. BUG=459136 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190536

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix an unrenamed variable #

Patch Set 3 : Fix inspector tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -304 lines) Patch
M LayoutTests/fast/dom/shadow/drag-and-drop-in-user-agent-shadow.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-type.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-type-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/breadcrumb-shadow-roots.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/elements-panel-shadow-selection-on-refresh.html View 1 chunk +14 lines, -14 lines 0 comments Download
M LayoutTests/inspector/elements/elements-panel-shadow-selection-on-refresh-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/reveal-shadow-dom-node.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/dom-breakpoints.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/dom-breakpoints-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Element.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Element.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/iterators/CharacterIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIterator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 6 chunks +16 lines, -16 lines 0 comments Download
M Source/core/editing/iterators/TextIteratorFlags.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/events/TreeScopeEventContext.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAudioElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImageFallbackHelper.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLInputElementTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseButtonInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/InputTypeView.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/shadow/MeterShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 8 chunks +12 lines, -12 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutSliderContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTheme.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderSearchField.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeElement.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hayato
PTAL
5 years, 10 months ago (2015-02-19 06:39:30 UTC) #2
kochi
lgtm Do you plan to update bunch of "UA shadow" "author shadow" "user-agent shadow" in ...
5 years, 10 months ago (2015-02-19 07:01:40 UTC) #3
hayato
On 2015/02/19 07:01:40, Takayoshi Kochi wrote: > lgtm > > Do you plan to update ...
5 years, 10 months ago (2015-02-19 07:18:04 UTC) #4
hayato
Adding tkent@ to reviewers as a Source/Owner.
5 years, 10 months ago (2015-02-19 07:21:17 UTC) #6
tkent
lgtm https://codereview.chromium.org/935283002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/935283002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp#newcode1300 Source/core/inspector/InspectorDOMAgent.cpp:1300: ShadowRoot* uaShadowRoot = closedShadowRoot(node); |uaShadowRoot| -> |closedShadowRoot|
5 years, 10 months ago (2015-02-19 08:19:03 UTC) #7
hayato
Looks some layout tests in inspectors are failing. Let me fix that. https://codereview.chromium.org/935283002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp ...
5 years, 10 months ago (2015-02-19 08:35:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935283002/40001
5 years, 10 months ago (2015-02-20 05:19:50 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 07:08:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190536

Powered by Google App Engine
This is Rietveld 408576698