[Extensions Toolbar Views] Override ShouldEnterPushedState in ToolbarActionView

[Extensions Toolbar Views] Override ShouldEnterPushedState in ToolbarActionView

crrev.com/48bb4848bf961d8e1b744ac6b4d8275d425279fc introduced a new behavior
for menu buttons where they don't enter pushed state if they can be dragged.
Since ToolbarActionView emulates either a LabelButton or a MenuButton depending
whether it has a popup, it should override this.

BUG=458041
Committed: https://crrev.com/ef5c7aee88bc06a4c62714e9c1d6fbd64968e795
Cr-Commit-Position: refs/heads/master@{#317435}

[Devlin, 2015-02-19 01:02:22]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Finnur, 2015-02-20 10:36:10]

LGTM

https://codereview.chromium.org/935163002/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/toolbar_action_view.cc (right):

https://codereview.chromium.org/935163002/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/toolbar_action_view.cc:235:
LabelButton::ShouldEnterPushedState(event);
style-nit: Maybe I'm getting tainted by writing mostly Java code at the moment,
but I thought we're now requesting these operators (? and :) to be at the front
of the line?

[Devlin, 2015-02-20 22:56:20]

https://codereview.chromium.org/935163002/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/toolbar_action_view.cc (right):

https://codereview.chromium.org/935163002/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/toolbar_action_view.cc:235:
LabelButton::ShouldEnterPushedState(event);
On 2015/02/20 10:36:10, Finnur wrote:
> style-nit: Maybe I'm getting tainted by writing mostly Java code at the
moment,
> but I thought we're now requesting these operators (? and :) to be at the
front
> of the line?

According to the conclusion in
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/P5FkBWIeaHs
either way is acceptable. :)

[Devlin, 2015-02-20 22:56:28]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-02-20 22:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935163002/1

[commit-bot: I haz the power, 2015-02-20 23:07:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-20 23:07:35]

Patchset 1 (id:??) landed as
https://crrev.com/ef5c7aee88bc06a4c62714e9c1d6fbd64968e795
Cr-Commit-Position: refs/heads/master@{#317435}