[Extensions Toolbar Views] Override ShouldEnterPushedState in ToolbarActionView

chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
index 7ef849da816108486dbfd6055e6ea641af9e2fd1..9765e3329c71b1eaffc861683246cb5b568176c3 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
@@ -229,6 +229,12 @@ scoped_ptr<LabelButtonBorder> ToolbarActionView::CreateDefaultBorder() const {
   return border.Pass();
 }
 
+bool ToolbarActionView::ShouldEnterPushedState(const ui::Event& event) {
+  return view_controller_->HasPopup(GetCurrentWebContents()) ?
+      MenuButton::ShouldEnterPushedState(event) :
+      LabelButton::ShouldEnterPushedState(event);

[Finnur, 2015/02/20 10:36:10]

style-nit: Maybe I'm getting tainted by writing mostly Java code at the moment,
but I thought we're now requesting these operators (? and :) to be at the front
of the line?

[Devlin, 2015/02/20 22:56:20]

According to the conclusion in
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/P5FkBWIeaHs
either way is acceptable. :)

+}
+
 gfx::ImageSkia ToolbarActionView::GetIconForTest() {
   return GetImage(views::Button::STATE_NORMAL);
 }