Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 935033003: Move LookupResult into crankshaft as that's now the only place where it's still used (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move LookupResult into crankshaft as that's now the only place where it's still used Additionally handlify the "transition" field so that GC can stop caring about it. BUG= Committed: https://crrev.com/7138634d5aadb5ae724daed629fae0b1623fbe0d Cr-Commit-Position: refs/heads/master@{#26718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -207 lines) Patch
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.h View 3 chunks +119 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/property.h View 1 chunk +0 lines, -131 lines 0 comments Download
M src/property.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-18 11:57:29 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-18 12:33:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935033003/1
5 years, 10 months ago (2015-02-18 12:59:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 13:21:42 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 13:21:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7138634d5aadb5ae724daed629fae0b1623fbe0d
Cr-Commit-Position: refs/heads/master@{#26718}

Powered by Google App Engine
This is Rietveld 408576698