Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: src/hydrogen.cc

Issue 935033003: Move LookupResult into crankshaft as that's now the only place where it's still used (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.h ('k') | src/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index c6bfe966257e5fc318d378b0062a50c496e88b27..50e3b2124df60ddc29331f0d9d4feb8f753c6a54 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5970,7 +5970,7 @@ bool HOptimizedGraphBuilder::PropertyAccessInfo::IsCompatible(
bool HOptimizedGraphBuilder::PropertyAccessInfo::LookupDescriptor() {
if (!map_->IsJSObjectMap()) return true;
- map_->LookupDescriptor(*name_, &lookup_);
+ lookup_.LookupDescriptor(*map_, *name_);
return LoadResult(map_);
}
@@ -6062,7 +6062,7 @@ bool HOptimizedGraphBuilder::PropertyAccessInfo::LookupInPrototypes() {
lookup_.NotFound();
return false;
}
- map->LookupDescriptor(*name_, &lookup_);
+ lookup_.LookupDescriptor(*map, *name_);
if (IsFound()) return LoadResult(map);
}
lookup_.NotFound();
@@ -6083,7 +6083,7 @@ bool HOptimizedGraphBuilder::PropertyAccessInfo::CanAccessMonomorphic() {
if (IsLoad()) return true;
if (IsAccessorConstant()) return true;
- map_->LookupTransition(*name_, NONE, &lookup_);
+ lookup_.LookupTransition(*map_, *name_, NONE);
if (lookup_.IsTransitionToData() && map_->unused_property_fields() > 0) {
// Construct the object field access.
int descriptor = transition()->LastAdded();
@@ -8171,13 +8171,25 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinFunctionCall(Call* expr) {
// static
+bool HOptimizedGraphBuilder::IsReadOnlyLengthDescriptor(
+ Handle<Map> jsarray_map) {
+ DCHECK(!jsarray_map->is_dictionary_map());
+ LookupResult lookup;
+ Isolate* isolate = jsarray_map->GetIsolate();
+ Handle<Name> length_string = isolate->factory()->length_string();
+ lookup.LookupDescriptor(*jsarray_map, *length_string);
+ return lookup.IsReadOnly();
+}
+
+
+// static
bool HOptimizedGraphBuilder::CanInlineArrayResizeOperation(
Handle<Map> receiver_map) {
return !receiver_map.is_null() &&
receiver_map->instance_type() == JS_ARRAY_TYPE &&
IsFastElementsKind(receiver_map->elements_kind()) &&
!receiver_map->is_dictionary_map() &&
- !JSArray::IsReadOnlyLengthDescriptor(receiver_map) &&
+ !IsReadOnlyLengthDescriptor(receiver_map) &&
!receiver_map->is_observed() && receiver_map->is_extensible();
}
« no previous file with comments | « src/hydrogen.h ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698