sky/engine/tonic/BUILD.gn - Issue 934863002: ParentNode#appendChild(null) shouldn't crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/tonic/BUILD.gn

Issue 934863002: ParentNode#appendChild(null) shouldn't crash (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: git cl format Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/tonic/BUILD.gn

diff --git a/sky/engine/tonic/BUILD.gn b/sky/engine/tonic/BUILD.gn

index 18c03c15e1c62c1f18872929a2ffdf2747f33da8..e795a1c1ab2318e82b0918b5e8303197013b4b2c 100644

--- a/sky/engine/tonic/BUILD.gn

+++ b/sky/engine/tonic/BUILD.gn

@@ -15,6 +15,8 @@ source_set("tonic") {

"dart_converter.h",

"dart_error.cc",

"dart_error.h",

+ "dart_exception_factory.cc",

+ "dart_exception_factory.h",

"dart_gc_context.cc",

"dart_gc_context.h",

"dart_gc_controller.cc",