sky/engine/tonic/BUILD.gn - Issue 934863002: ParentNode#appendChild(null) shouldn't crash

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/tonic/BUILD.gn

Issue 934863002: ParentNode#appendChild(null) shouldn't crash (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: git cl format Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("tonic") {	5 source_set("tonic") {

6 sources = [	6 sources = [

7 "dart_api_scope.h",	7 "dart_api_scope.h",

8 "dart_builtin.cc",	8 "dart_builtin.cc",

9 "dart_builtin.h",	9 "dart_builtin.h",

10 "dart_class_library.cc",	10 "dart_class_library.cc",

11 "dart_class_library.h",	11 "dart_class_library.h",

12 "dart_class_provider.cc",	12 "dart_class_provider.cc",

13 "dart_class_provider.h",	13 "dart_class_provider.h",

14 "dart_converter.cc",	14 "dart_converter.cc",

15 "dart_converter.h",	15 "dart_converter.h",

16 "dart_error.cc",	16 "dart_error.cc",

17 "dart_error.h",	17 "dart_error.h",

	18 "dart_exception_factory.cc",

	19 "dart_exception_factory.h",

18 "dart_gc_context.cc",	20 "dart_gc_context.cc",

19 "dart_gc_context.h",	21 "dart_gc_context.h",

20 "dart_gc_controller.cc",	22 "dart_gc_controller.cc",

21 "dart_gc_controller.h",	23 "dart_gc_controller.h",

22 "dart_gc_visitor.cc",	24 "dart_gc_visitor.cc",

23 "dart_gc_visitor.h",	25 "dart_gc_visitor.h",

24 "dart_isolate_scope.cc",	26 "dart_isolate_scope.cc",

25 "dart_isolate_scope.h",	27 "dart_isolate_scope.h",

26 "dart_persistent_value.cc",	28 "dart_persistent_value.cc",

27 "dart_persistent_value.h",	29 "dart_persistent_value.h",

(...skipping 12 matching lines...) Expand all Loading...
40	42

41 deps = [	43 deps = [

42 "//base",	44 "//base",

43 "//sky/engine/wtf",	45 "//sky/engine/wtf",

44 ]	46 ]

45	47

46 public_deps = [	48 public_deps = [

47 "//dart/runtime/bin:libdart_withcore",	49 "//dart/runtime/bin:libdart_withcore",

48 ]	50 ]

49 }	51 }

OLD	NEW

« no previous file with comments | « no previous file | sky/engine/tonic/dart_exception_factory.h » ('j') | sky/engine/tonic/dart_exception_factory.cc » ('J')