Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934853002: Move and rename RenderQuote and RenderWordBreak. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
dsinclair
CC:
blink-reviews, blink-reviews-html_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move and rename RenderQuote and RenderWordBreak. RenderQuote -> LayoutQuote RenderWordBreak -> LayoutWordBreak BUG=450612 TBR=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -880 lines) Patch
M LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-generated-content/quote-crash-93750.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/quote-crash-93750-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/css-generated-content/005-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/css-generated-content/beforeAfter-interdocument-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/css-generated-content/no-openclose-quote-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/linux/fast/css-generated-content/005-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/css-generated-content/beforeAfter-interdocument-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/css-generated-content/no-openclose-quote-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/css-generated-content/wbr-with-before-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/invalid/021-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/linux/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/mac/fast/css-generated-content/005-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/invalid/021-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/mac/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/text/wbr-pre-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/wbr-pre-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/wbr-pre-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/css-generated-content/005-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/css-generated-content/beforeAfter-interdocument-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/css-generated-content/no-openclose-quote-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/css-generated-content/wbr-with-before-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/invalid/021-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/antialiasedtext/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/antialiasedtext/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/virtual/antialiasedtext/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win/fast/css-generated-content/005-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/css-generated-content/beforeAfter-interdocument-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/css-generated-content/no-openclose-quote-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/css-generated-content/wbr-with-before-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/invalid/021-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/text/wbr-pre-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/wbr-in-pre-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/wbr-pre-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/wbr-styled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/table/quote-text-around-iframe-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/text/wbr-expected.txt View 9 chunks +13 lines, -13 lines 0 comments Download
M Source/core/core.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/PseudoElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLWBRElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/layout/LayoutQuote.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/layout/LayoutQuote.cpp View 14 chunks +23 lines, -23 lines 0 comments Download
A + Source/core/layout/LayoutWordBreak.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/layout/LayoutWordBreak.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/layout/style/ContentData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/rendering/RenderQuote.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/core/rendering/RenderQuote.cpp View 1 chunk +0 lines, -408 lines 0 comments Download
M Source/core/rendering/RenderView.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/rendering/RenderWordBreak.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/rendering/RenderWordBreak.cpp View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-17 17:00:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934853002/1
5 years, 10 months ago (2015-02-17 17:03:29 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:27:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190344

Powered by Google App Engine
This is Rietveld 408576698