Remove ability to launch ephemeral apps from the app launcher.

Remove ability to launch ephemeral apps from the app launcher.

The only way to launch ephemeral apps after this patch is via the
webstore, and only if the kEnableEphemeralAppsInWebstore flag is set.

This is because ephemeral apps are not ready for release, and if/when
they are released for UX reasons theya should only be available from
the webstore.

BUG=459090
Committed: https://crrev.com/a5d90f637575a5077217e201292dafb411038326
Cr-Commit-Position: refs/heads/master@{#316544}

[benwells, 2015-02-17 06:28:59]

benwells@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-02-17 08:01:47]

lgtm with the one comment.

https://codereview.chromium.org/934683002/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/webstore/webstore_result.cc (right):

https://codereview.chromium.org/934683002/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/webstore/webstore_result.cc:165:
actions.push_back(Action(
You need to remove the following IDS strings from
chrome/app/generated_resources.grd:

- IDS_WEBSTORE_RESULT_INSTALL
- IDS_WEBSTORE_RESULT_LAUNCH
- IDS_WEBSTORE_RESULT_LAUNCH_APP_TOOLTIP

(As far as I can tell they aren't used anywhere else.)

[benwells, 2015-02-17 08:10:31]

New patchsets have been uploaded after l-g-t-m from mgiuca@chromium.org

[benwells, 2015-02-17 08:11:11]

https://codereview.chromium.org/934683002/diff/20001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/webstore/webstore_result.cc (right):

https://codereview.chromium.org/934683002/diff/20001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/webstore/webstore_result.cc:165:
actions.push_back(Action(
On 2015/02/17 08:01:47, Matt Giuca wrote:
> You need to remove the following IDS strings from
> chrome/app/generated_resources.grd:
> 
> - IDS_WEBSTORE_RESULT_INSTALL
> - IDS_WEBSTORE_RESULT_LAUNCH
> - IDS_WEBSTORE_RESULT_LAUNCH_APP_TOOLTIP
> 
> (As far as I can tell they aren't used anywhere else.)

Done.

[benwells, 2015-02-17 08:11:15]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-02-17 08:11:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934683002/40001

[commit-bot: I haz the power, 2015-02-17 08:57:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-17 08:58:23]

Patchset 3 (id:??) landed as
https://crrev.com/a5d90f637575a5077217e201292dafb411038326
Cr-Commit-Position: refs/heads/master@{#316544}