chrome/browser/apps/ephemeral_app_launcher_browsertest.cc - Issue 934683002: Remove ability to launch ephemeral apps from the app launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

Issue 934683002: Remove ability to launch ephemeral apps from the app launcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove resources Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/ephemeral_app_launcher.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc b/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

index b1e161e670f241ea29fe3e632ff3c939cfb39c97..4898431f2963f6b6991023a83c9bf241e6b68286 100644

--- a/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher_browsertest.cc

@@ -22,7 +22,6 @@

#include "extensions/browser/management_policy.h"

#include "extensions/browser/process_manager.h"

#include "extensions/test/extension_test_message_listener.h"

-#include "ui/app_list/app_list_switches.h"

using extensions::Extension;

using extensions::ExtensionPrefs;

@@ -203,7 +202,7 @@ class EphemeralAppLauncherTest : public WebstoreInstallerTest {

extensions::ProcessManager::SetEventPageSuspendingTimeForTesting(1);

// Enable ephemeral apps flag.

- command_line->AppendSwitch(app_list::switches::kEnableExperimentalAppList);

+ command_line->AppendSwitch(switches::kEnableEphemeralAppsInWebstore);

}

void SetUpOnMainThread() override {

@@ -313,8 +312,6 @@ class EphemeralAppLauncherTestDisabled : public EphemeralAppLauncherTest {

// Verifies that an ephemeral app will not be installed and launched if the

// feature is disabled.

IN_PROC_BROWSER_TEST_F(EphemeralAppLauncherTestDisabled, FeatureDisabled) {

- base::CommandLine::ForCurrentProcess()->AppendSwitch(

- app_list::switches::kDisableExperimentalAppList);

RunLaunchTest(

kDefaultAppCrxFilename, webstore_install::LAUNCH_FEATURE_DISABLED, false);

EXPECT_FALSE(GetInstalledExtension(kDefaultAppId));