Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 934533002: ifdefs around LayoutDescriptor::IsConsistenWithMap() removed. (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ifdefs around LayoutDescriptor::IsConsistenWithMap() removed. This avoids potential mess with different compilation modes. Committed: https://crrev.com/6834d3abdf9c463e4c03847077b56bd688c2d753 Cr-Commit-Position: refs/heads/master@{#26656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -44 lines) Patch
M src/layout-descriptor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/layout-descriptor.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 7 chunks +8 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 10 months ago (2015-02-16 11:12:37 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-16 11:27:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934533002/1
5 years, 10 months ago (2015-02-16 11:28:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 11:29:36 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 11:29:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6834d3abdf9c463e4c03847077b56bd688c2d753
Cr-Commit-Position: refs/heads/master@{#26656}

Powered by Google App Engine
This is Rietveld 408576698