Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: test/cctest/test-unboxed-doubles.cc

Issue 934533002: ifdefs around LayoutDescriptor::IsConsistenWithMap() removed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/layout-descriptor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-unboxed-doubles.cc
diff --git a/test/cctest/test-unboxed-doubles.cc b/test/cctest/test-unboxed-doubles.cc
index d4b01cac0924f7026d83cf5ad7528eea890b5970..fdcac3af355067c2d1e5945ef39e83cdec439692 100644
--- a/test/cctest/test-unboxed-doubles.cc
+++ b/test/cctest/test-unboxed-doubles.cc
@@ -30,11 +30,7 @@ static void InitializeVerifiedMapDescriptors(
Map* map, DescriptorArray* descriptors,
LayoutDescriptor* layout_descriptor) {
map->InitializeDescriptors(descriptors, layout_descriptor);
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(layout_descriptor->IsConsistentWithMap(map));
- }
-#endif
+ CHECK(layout_descriptor->IsConsistentWithMap(map));
}
@@ -228,11 +224,7 @@ TEST(LayoutDescriptorBasicSlow) {
}
CHECK(layout_desc->IsSlowLayout());
CHECK(!layout_desc->IsFastPointerLayout());
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(layout_descriptor->IsConsistentWithMap(*map));
- }
-#endif
+ CHECK(layout_descriptor->IsConsistentWithMap(*map));
}
}
@@ -646,11 +638,7 @@ static Handle<LayoutDescriptor> TestLayoutDescriptorAppend(
map->InitializeDescriptors(*descriptors, *layout_descriptor);
}
Handle<LayoutDescriptor> layout_descriptor(map->layout_descriptor(), isolate);
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(layout_descriptor->IsConsistentWithMap(*map));
- }
-#endif
+ CHECK(layout_descriptor->IsConsistentWithMap(*map));
return layout_descriptor;
}
@@ -777,20 +765,12 @@ static Handle<LayoutDescriptor> TestLayoutDescriptorAppendIfFastOrUseFull(
CHECK(layout_desc->IsTagged(field_index + field_width_in_words));
}
}
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(map->layout_descriptor()->IsConsistentWithMap(*map));
- }
-#endif
+ CHECK(map->layout_descriptor()->IsConsistentWithMap(*map));
}
Handle<LayoutDescriptor> layout_descriptor(map->GetLayoutDescriptor(),
isolate);
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(layout_descriptor->IsConsistentWithMap(*map));
- }
-#endif
+ CHECK(layout_descriptor->IsConsistentWithMap(*map));
return layout_descriptor;
}
@@ -1151,11 +1131,7 @@ TEST(LayoutDescriptorSharing) {
}
Handle<LayoutDescriptor> split_layout_descriptor(
split_map->layout_descriptor(), isolate);
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(split_layout_descriptor->IsConsistentWithMap(*split_map));
- }
-#endif
+ CHECK(split_layout_descriptor->IsConsistentWithMap(*split_map));
CHECK(split_layout_descriptor->IsSlowLayout());
CHECK(split_map->owns_descriptors());
@@ -1168,11 +1144,7 @@ TEST(LayoutDescriptorSharing) {
// Layout descriptors should be shared with |split_map|.
CHECK(map1->owns_descriptors());
CHECK_EQ(*split_layout_descriptor, map1->layout_descriptor());
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(map1->layout_descriptor()->IsConsistentWithMap(*map1));
- }
-#endif
+ CHECK(map1->layout_descriptor()->IsConsistentWithMap(*map1));
Handle<Map> map2 = Map::CopyWithField(split_map, MakeString("bar"), any_type,
NONE, Representation::Tagged(),
@@ -1181,11 +1153,7 @@ TEST(LayoutDescriptorSharing) {
// Layout descriptors should not be shared with |split_map|.
CHECK(map2->owns_descriptors());
CHECK_NE(*split_layout_descriptor, map2->layout_descriptor());
-#ifdef VERIFY_HEAP
- if (FLAG_verify_heap) {
- DCHECK(map2->layout_descriptor()->IsConsistentWithMap(*map2));
- }
-#endif
+ CHECK(map2->layout_descriptor()->IsConsistentWithMap(*map2));
}
« no previous file with comments | « src/layout-descriptor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698