Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 934383002: Follow-up to https://codereview.chromium.org/938853002 (Closed)

Created:
5 years, 10 months ago by dougk
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow-up to https://codereview.chromium.org/938853002 Address comments of RCH BUG=none Committed: https://crrev.com/c2a5ab105e271c7ccc49121d677b3695017af442 Cr-Commit-Position: refs/heads/master@{#316945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M net/quic/quic_server_bin.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dougk
Your way is indeed nicer but CQ beat me.
5 years, 10 months ago (2015-02-19 00:26:55 UTC) #2
Ryan Hamilton
lgtm Thanks for doing this!
5 years, 10 months ago (2015-02-19 00:37:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934383002/1
5 years, 10 months ago (2015-02-19 00:39:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 01:07:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:08:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2a5ab105e271c7ccc49121d677b3695017af442
Cr-Commit-Position: refs/heads/master@{#316945}

Powered by Google App Engine
This is Rietveld 408576698