Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 934353003: Remove unused menu item types. (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused menu item types. two_button_menu_item was added in https://codereview.chromium.org/608283004 but it is not used anymore due to menu button removal from the menu popup. four_button_menu_item was also added to support menu button inside the menu popup. BUG=None Committed: https://crrev.com/8418bc1910647ab3364118b26596303170d58e05 Cr-Commit-Position: refs/heads/master@{#317103}

Patch Set 1 #

Patch Set 2 : Remove four_button_menu_item too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -149 lines) Patch
D chrome/android/java/res/layout/four_button_menu_item.xml View 1 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/android/java/res/layout/two_button_menu_item.xml View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 1 5 chunks +3 lines, -74 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
tedchoc: PTAL
5 years, 10 months ago (2015-02-19 01:51:15 UTC) #2
Ted C
lgtm
5 years, 10 months ago (2015-02-19 19:13:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934353003/20001
5 years, 10 months ago (2015-02-19 19:15:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 19:35:22 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:35:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8418bc1910647ab3364118b26596303170d58e05
Cr-Commit-Position: refs/heads/master@{#317103}

Powered by Google App Engine
This is Rietveld 408576698