Fix the menu alignment for the three button menu.

Fix the menu alignment for the three button menu.

Also, fixes a crash for an index out of bounds check.

Also also, adds two button layout for when two icons are shown in the top row.

BUG=416552
Committed: https://crrev.com/003cb9e92015a5b9c1fa08a7cc8eac2be037a219
Cr-Commit-Position: refs/heads/master@{#298110}

[Ted C, 2014-10-02 22:47:05]

tedchoc@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Ted C, 2014-10-02 22:47:06]

PTAL

[David Trainor- moved to gerrit, 2014-10-03 17:19:18]

https://codereview.chromium.org/608283004/diff/1/chrome/android/java/res/layo...
File chrome/android/java/res/layout/three_button_menu_item.xml (right):

https://codereview.chromium.org/608283004/diff/1/chrome/android/java/res/layo...
chrome/android/java/res/layout/three_button_menu_item.xml:31:
android:layout_width="59dp"
Do we need these changes?  Shouldn't Java side handle it?  Do we need to reset
the weight?

https://codereview.chromium.org/608283004/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
(right):

https://codereview.chromium.org/608283004/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:184:
setupMenuButton(holder.buttons[2]);
Ew thanks!  Nice catch.

[Ted C, 2014-10-03 18:30:02]

https://codereview.chromium.org/608283004/diff/1/chrome/android/java/res/layo...
File chrome/android/java/res/layout/three_button_menu_item.xml (right):

https://codereview.chromium.org/608283004/diff/1/chrome/android/java/res/layo...
chrome/android/java/res/layout/three_button_menu_item.xml:31:
android:layout_width="59dp"
On 2014/10/03 17:19:17, David Trainor wrote:
> Do we need these changes?  Shouldn't Java side handle it?  Do we need to reset
> the weight?

Yeah, it turned out we only needed to clear the weight on the java side.

[David Trainor- moved to gerrit, 2014-10-03 20:40:06]

lgtm

[Ted C, 2014-10-03 20:41:50]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2014-10-03 20:42:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/608283004/20001

[commit-bot: I haz the power, 2014-10-03 22:55:18]

Committed patchset #2 (id:20001) as 9cce09295c0d7015d2232251da9b643398f8b250

[commit-bot: I haz the power, 2014-10-03 22:56:18]

Patchset 2 (id:??) landed as
https://crrev.com/003cb9e92015a5b9c1fa08a7cc8eac2be037a219
Cr-Commit-Position: refs/heads/master@{#298110}