Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934283002: gm to test hairlines which fill RenderTarget (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gm to test hairlines which fill RenderTarget BUG=skia: Committed: https://skia.googlesource.com/skia/+/6364807151ddf51c4197603aa185b3336f325357

Patch Set 1 #

Patch Set 2 : adding gm #

Patch Set 3 : feedback inc #

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -19 lines) Patch
A gm/stlouisarch.cpp View 1 2 3 1 chunk +97 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 3 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
joshualitt
ptal
5 years, 10 months ago (2015-02-18 16:05:31 UTC) #3
joshualitt
On 2015/02/18 16:05:31, joshualitt wrote: > ptal ptal
5 years, 10 months ago (2015-02-19 14:59:59 UTC) #4
bsalomon
lgtm
5 years, 10 months ago (2015-02-19 15:37:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934283002/40001
5 years, 10 months ago (2015-02-19 15:41:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2566)
5 years, 10 months ago (2015-02-19 16:27:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934283002/60001
5 years, 10 months ago (2015-02-19 18:19:45 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 18:25:27 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6364807151ddf51c4197603aa185b3336f325357

Powered by Google App Engine
This is Rietveld 408576698