Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 934173004: Remove handle wrappers from basic elements accessors (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove handle wrappers from basic elements accessors BUG= R=yangguo@chromium.org Committed: https://crrev.com/40b7c513c696f405af0ae3e74e844d3c341bc3f2 Cr-Commit-Position: refs/heads/master@{#26736}

Patch Set 1 #

Patch Set 2 : Don't handlify probe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -93 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.h View 4 chunks +10 lines, -17 lines 0 comments Download
M src/elements.cc View 1 20 chunks +51 lines, -68 lines 0 comments Download
M src/objects.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-array.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-19 07:52:03 UTC) #2
Yang
On 2015/02/19 07:52:03, Toon Verwaest wrote: > PTAL LGTM. Suggestion though: inside the dehandlified methods, ...
5 years, 10 months ago (2015-02-19 07:55:35 UTC) #3
Toon Verwaest
Committed patchset #2 (id:20001) manually as 40b7c513c696f405af0ae3e74e844d3c341bc3f2 (presubmit successful).
5 years, 10 months ago (2015-02-19 08:18:13 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/40b7c513c696f405af0ae3e74e844d3c341bc3f2 Cr-Commit-Position: refs/heads/master@{#26736}
5 years, 10 months ago (2015-02-19 08:18:16 UTC) #5
Toon Verwaest
5 years, 10 months ago (2015-02-19 09:04:07 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/932693003/ by verwaest@chromium.org.

The reason for reverting is: Breakage.

Powered by Google App Engine
This is Rietveld 408576698