src/builtins.cc - Issue 934173004: Remove handle wrappers from basic elements accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 934173004: Remove handle wrappers from basic elements accessors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Don't handlify probe Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 21c246ca42d256ba3c9fd0252aad77907780f0d3..f2b55c294cc40edd4786aecea9eb53e4ab23e09c 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -666,7 +666,7 @@ BUILTIN(ArraySlice) {

bool packed = true;

ElementsAccessor* accessor = ElementsAccessor::ForKind(kind);

for (int i = k; i < final; i++) {

- if (!accessor->HasElement(object, i, elms)) {

+ if (!accessor->HasElement(*object, i, *elms)) {

packed = false;

break;

}

« no previous file with comments | « no previous file | src/elements.h » ('j') | no next file with comments »