Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: Source/core/html/forms/TextFieldInputType.h

Issue 934163004: Modernize coding style in core/html/forms/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/forms/TelephoneInputType.h ('k') | Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/TextFieldInputType.h
diff --git a/Source/core/html/forms/TextFieldInputType.h b/Source/core/html/forms/TextFieldInputType.h
index 29f01f3a1a969ec377cb7e12c2df5b6cc016862f..227cf214b8c367371641ffc2fad9ea14d342682a 100644
--- a/Source/core/html/forms/TextFieldInputType.h
+++ b/Source/core/html/forms/TextFieldInputType.h
@@ -47,24 +47,22 @@ public:
protected:
TextFieldInputType(HTMLInputElement&);
- virtual ~TextFieldInputType();
- virtual bool canSetSuggestedValue() override;
- virtual void handleKeydownEvent(KeyboardEvent*) override;
- void handleKeydownEventForSpinButton(KeyboardEvent*);
+ ~TextFieldInputType() override;
+ bool canSetSuggestedValue() override;
+ void handleKeydownEvent(KeyboardEvent*) override;
- virtual bool needsContainer() const { return false; }
- bool shouldHaveSpinButton() const;
- virtual void createShadowSubtree() override;
- virtual void destroyShadowSubtree() override;
- virtual void attributeChanged() override;
- virtual void disabledAttributeChanged() override;
- virtual void readonlyAttributeChanged() override;
- virtual bool supportsReadOnly() const override;
- virtual void handleFocusEvent(Element* oldFocusedNode, WebFocusType) override final;
- virtual void handleBlurEvent() override final;
- virtual void setValue(const String&, bool valueChanged, TextFieldEventBehavior) override;
- virtual void updateView() override;
+ void createShadowSubtree() override;
+ void destroyShadowSubtree() override;
+ void attributeChanged() override;
+ void disabledAttributeChanged() override;
+ void readonlyAttributeChanged() override;
+ bool supportsReadOnly() const override;
+ void handleFocusEvent(Element* oldFocusedNode, WebFocusType) final;
+ void handleBlurEvent() final;
+ void setValue(const String&, bool valueChanged, TextFieldEventBehavior) override;
+ void updateView() override;
+ virtual bool needsContainer() const { return false; }
virtual String convertFromVisibleValue(const String&) const;
enum ValueChangeState {
ValueChangeStateNone,
@@ -72,30 +70,32 @@ protected:
};
virtual void didSetValueByUserEdit(ValueChangeState);
+ void handleKeydownEventForSpinButton(KeyboardEvent*);
+ bool shouldHaveSpinButton() const;
Element* containerElement() const;
private:
- virtual bool shouldShowFocusRingOnMouseFocus() const override final;
- virtual bool isTextField() const override final;
- virtual bool valueMissing(const String&) const override;
- virtual void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) override;
- virtual void forwardEvent(Event*) override final;
- virtual bool shouldSubmitImplicitly(Event*) override final;
- virtual LayoutObject* createRenderer(const LayoutStyle&) const override;
- virtual String sanitizeValue(const String&) const override;
- virtual bool shouldRespectListAttribute() override;
- virtual void listAttributeTargetChanged() override;
- virtual void updatePlaceholderText() override final;
- virtual bool appendFormData(FormDataList&, bool multipart) const override;
- virtual void subtreeHasChanged() override final;
+ bool shouldShowFocusRingOnMouseFocus() const final;
+ bool isTextField() const final;
+ bool valueMissing(const String&) const override;
+ void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) override;
+ void forwardEvent(Event*) final;
+ bool shouldSubmitImplicitly(Event*) final;
+ LayoutObject* createRenderer(const LayoutStyle&) const override;
+ String sanitizeValue(const String&) const override;
+ bool shouldRespectListAttribute() override;
+ void listAttributeTargetChanged() override;
+ void updatePlaceholderText() final;
+ bool appendFormData(FormDataList&, bool multipart) const override;
+ void subtreeHasChanged() final;
// SpinButtonElement::SpinButtonOwner functions.
- virtual void focusAndSelectSpinButtonOwner() override final;
- virtual bool shouldSpinButtonRespondToMouseEvents() override final;
- virtual bool shouldSpinButtonRespondToWheelEvents() override final;
- virtual void spinButtonStepDown() override final;
- virtual void spinButtonStepUp() override final;
- virtual void spinButtonDidReleaseMouseCapture(SpinButtonElement::EventDispatch) override final;
+ void focusAndSelectSpinButtonOwner() final;
+ bool shouldSpinButtonRespondToMouseEvents() final;
+ bool shouldSpinButtonRespondToWheelEvents() final;
+ void spinButtonStepDown() final;
+ void spinButtonStepUp() final;
+ void spinButtonDidReleaseMouseCapture(SpinButtonElement::EventDispatch) final;
SpinButtonElement* spinButtonElement() const;
};
« no previous file with comments | « Source/core/html/forms/TelephoneInputType.h ('k') | Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698