Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933823004: Revert of Respect the smooth scrolling setting in LayerScrollableArea. (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
ajuma, Nate Chapin, skobes
CC:
blink-reviews, blink-layers+watch_chromium.org, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering, weiliangc
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Respect the smooth scrolling setting in LayerScrollableArea. (patchset #4 id:120001 of https://codereview.chromium.org/882813005/) Reason for revert: Regresses scrolling on Mac: http://crbug.com/459739 Original issue's description: > Respect the smooth scrolling setting in LayerScrollableArea. > > This was previously done in http://crrev.com/214953004 but reverted due to > http://crbug.com/383946. With http://crrev.com/831393003 it should be safe to > re-land. (This is also needed for http://crbug.com/417782 because everything > will go through the LayerScrollableArea path.) > > BUG=575, 417782 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190002 TBR=ajuma@chromium.org,japhet@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=575, 417782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -109 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html View 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/fast/scroll-behavior/overflow-scroll-animates-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/precise-delta-no-animate.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/precise-delta-no-animate-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayerScrollableArea.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ccameron
Created Revert of Respect the smooth scrolling setting in LayerScrollableArea.
5 years, 10 months ago (2015-02-18 21:54:25 UTC) #1
skobes
lgtm
5 years, 10 months ago (2015-02-18 21:57:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933823004/1
5 years, 10 months ago (2015-02-19 03:25:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933823004/1
5 years, 10 months ago (2015-02-19 09:34:13 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 11:20:33 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190451

Powered by Google App Engine
This is Rietveld 408576698