Cleanup: Remove DCHECK_RESULT macro.

Cleanup: Remove DCHECK_RESULT macro.

BUG=None
R=bmeurer@chromium.org
LOG=N

Committed: https://crrev.com/b00ea0f1254f0746260b1d2841610833cdf4bd09
Cr-Commit-Position: refs/heads/master@{#26733}

[tfarina, 2015-02-16 17:06:53]

PTAL!

https://codereview.chromium.org/933673002/diff/1/src/base/logging.h
File src/base/logging.h (left):

https://codereview.chromium.org/933673002/diff/1/src/base/logging.h#oldcode165
src/base/logging.h:165: #define DCHECK_RESULT(expr)    (expr)
Is this patch correct, or is it something else because it is different in in
Release build?

[Benedikt Meurer, 2015-02-16 18:53:25]

This is wrong, because DCHECK_RESULT evaluates the expr even in release builds,
while DCHECK does not.

[tfarina, 2015-02-16 20:31:27]

On 2015/02/16 18:53:25, Benedikt Meurer wrote:
> This is wrong, because DCHECK_RESULT evaluates the expr even in release
builds,
> while DCHECK does not.

OK, so what is the plan for this TODO? Could you share your ideas with me, so I
can look at implementing the right thing for this patch?

[Benedikt Meurer, 2015-02-17 05:34:28]

On 2015/02/16 at 20:31:27, tfarina wrote:
> On 2015/02/16 18:53:25, Benedikt Meurer wrote:
> > This is wrong, because DCHECK_RESULT evaluates the expr even in release
builds,
> > while DCHECK does not.
> 
> OK, so what is the plan for this TODO? Could you share your ideas with me, so
I can look at implementing the right thing for this patch?

Well, probably just use a sequence of

bool result = <whatever>;
DCHECK(result);
USE(result);

instead of

DCHECK_RESULT(<whatever>);

in jsregexp.cc. Not the most beautiful solution, but does the job.

[Jakob Kummerow, 2015-02-17 09:05:35]

Why is 

> bool result = <whatever>;
> DCHECK(result);
> USE(result);

better than

> DCHECK_RESULT(<whatever>);

?

Also, does the first proposed patch set pass the test suite? I'd be shocked if
it did.

[tfarina, 2015-02-18 14:49:18]

Done. PTAL Benedikt!

[Benedikt Meurer, 2015-02-19 05:41:59]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-02-19 05:42:00]

lgtm

[commit-bot: I haz the power, 2015-02-19 05:42:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/933673002/20001

[commit-bot: I haz the power, 2015-02-19 05:47:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 05:47:50]

Patchset 2 (id:??) landed as
https://crrev.com/b00ea0f1254f0746260b1d2841610833cdf4bd09
Cr-Commit-Position: refs/heads/master@{#26733}