Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: src/base/logging.h

Issue 933673002: Cleanup: Remove DCHECK_RESULT macro. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: USE Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/jsregexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/logging.h
diff --git a/src/base/logging.h b/src/base/logging.h
index f54f10c1cde65e0d38d6726f48cd60ada9dfba18..511ebf1e9c3e5af344eaaf809fb0726003768fe5 100644
--- a/src/base/logging.h
+++ b/src/base/logging.h
@@ -149,9 +149,7 @@ void DumpBacktrace();
// The DCHECK macro is equivalent to CHECK except that it only
// generates code in debug builds.
-// TODO(bmeurer): DCHECK_RESULT(expr) must die!
#ifdef DEBUG
-#define DCHECK_RESULT(expr) CHECK(expr)
#define DCHECK(condition) CHECK(condition)
#define DCHECK_EQ(v1, v2) CHECK_EQ(v1, v2)
#define DCHECK_NE(v1, v2) CHECK_NE(v1, v2)
@@ -162,7 +160,6 @@ void DumpBacktrace();
#define DCHECK_NOT_NULL(val) CHECK_NOT_NULL(val)
#define DCHECK_IMPLIES(v1, v2) CHECK_IMPLIES(v1, v2)
#else
-#define DCHECK_RESULT(expr) (expr)
#define DCHECK(condition) ((void) 0)
#define DCHECK_EQ(v1, v2) ((void) 0)
#define DCHECK_NE(v1, v2) ((void) 0)
« no previous file with comments | « no previous file | src/jsregexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698