Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933663002: Make use of new method for setting lengths in presentation style. (Closed)

Created:
5 years, 10 months ago by Erik Dahlström (inactive)
Modified:
5 years, 10 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make use of new method for setting lengths in presentation style. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190297

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +7 lines, -14 lines 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +4 lines, -9 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Erik Dahlström (inactive)
Avoids a temporary + makes code easier to read. PTAL.
5 years, 10 months ago (2015-02-16 17:20:17 UTC) #2
fs
lgtm https://codereview.chromium.org/933663002/diff/1/Source/core/svg/SVGSVGElement.cpp File Source/core/svg/SVGSVGElement.cpp (right): https://codereview.chromium.org/933663002/diff/1/Source/core/svg/SVGSVGElement.cpp#newcode267 Source/core/svg/SVGSVGElement.cpp:267: } else if (isOutermostSVGSVGElement() && (property == m_width ...
5 years, 10 months ago (2015-02-16 17:34:32 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/933663002/diff/1/Source/core/svg/SVGSVGElement.cpp File Source/core/svg/SVGSVGElement.cpp (right): https://codereview.chromium.org/933663002/diff/1/Source/core/svg/SVGSVGElement.cpp#newcode267 Source/core/svg/SVGSVGElement.cpp:267: } else if (isOutermostSVGSVGElement() && (property == m_width || ...
5 years, 10 months ago (2015-02-17 08:06:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933663002/1
5 years, 10 months ago (2015-02-17 08:06:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 08:11:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190297

Powered by Google App Engine
This is Rietveld 408576698