Source/core/svg/SVGImageElement.cpp - Issue 933663002: Make use of new method for setting lengths in presentation style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGImageElement.cpp

Issue 933663002: Make use of new method for setting lengths in presentation style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGImageElement.cpp

diff --git a/Source/core/svg/SVGImageElement.cpp b/Source/core/svg/SVGImageElement.cpp

index 22ed66350b041b9c7d380548610b03bf66fae985..6f87c714c2babc5891bb7c1bc0d75d9329d3a509 100644

--- a/Source/core/svg/SVGImageElement.cpp

+++ b/Source/core/svg/SVGImageElement.cpp

@@ -110,9 +110,9 @@ void SVGImageElement::collectStyleForPresentationAttribute(const QualifiedName&

RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);

if (property == m_width)

- addPropertyToPresentationAttributeStyle(style, CSSPropertyWidth, value);

+ addSVGLengthPropertyToPresentationAttributeStyle(style, CSSPropertyWidth, *m_width->currentValue());

else if (property == m_height)

- addPropertyToPresentationAttributeStyle(style, CSSPropertyHeight, value);

+ addSVGLengthPropertyToPresentationAttributeStyle(style, CSSPropertyHeight, *m_height->currentValue());

else if (property == m_x)

addSVGLengthPropertyToPresentationAttributeStyle(style, CSSPropertyX, *m_x->currentValue());

else if (property == m_y)

« no previous file with comments | « Source/core/svg/SVGForeignObjectElement.cpp ('k') | Source/core/svg/SVGSVGElement.cpp » ('j') | Source/core/svg/SVGSVGElement.cpp » ('J')