Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: public/web/WebInputEvent.h

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added key=value pair for screencastview.js Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« public/platform/Platform.h ('K') | « public/platform/Platform.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebInputEvent.h
diff --git a/public/web/WebInputEvent.h b/public/web/WebInputEvent.h
index c9e73c03e601bcf2e32b372c05ea2c2ca29eea13..173f6140630759b29cf1b5cc6c1f0316ad815fec 100644
--- a/public/web/WebInputEvent.h
+++ b/public/web/WebInputEvent.h
@@ -247,6 +247,10 @@ public:
// code enum are defined in ui/events/keycodes/dom4/keycode_converter_data.h.
int domCode;
+ // The DOM key enum of the key pressed as passed by the embedder. DOM
Wez 2015/03/04 23:00:26 This (and the above domCode field) are embedder en
Habib Virji 2015/03/09 15:14:27 As previously stated, it was added as rbyers sugge
Rick Byers 2015/04/20 19:49:46 I don't have a strong preference. It's not like t
Habib Virji 2015/04/29 16:00:50 @wez: Do you have a suggestion on this?
Rick Byers 2015/04/29 17:34:26 Since we haven't heard from wez@ on this yet, I su
+ // key enum are defined in ui/events/keycodes/dom3/dom_key_data.h
+ int domKey;
+
// This identifies whether this event was tagged by the system as being
// a "system key" event (see
// http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx for
« public/platform/Platform.h ('K') | « public/platform/Platform.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698