Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: public/web/WebInputEvent.h

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added key=value pair for screencastview.js Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« public/platform/Platform.h ('K') | « public/platform/Platform.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 240
241 // The actual key code genenerated by the platform. The DOM spec runs 241 // The actual key code genenerated by the platform. The DOM spec runs
242 // on Windows-equivalent codes (thus |windowsKeyCode| above) but it 242 // on Windows-equivalent codes (thus |windowsKeyCode| above) but it
243 // doesn't hurt to have this one around. 243 // doesn't hurt to have this one around.
244 int nativeKeyCode; 244 int nativeKeyCode;
245 245
246 // The DOM code enum of the key pressed as passed by the embedder. DOM 246 // The DOM code enum of the key pressed as passed by the embedder. DOM
247 // code enum are defined in ui/events/keycodes/dom4/keycode_converter_data.h . 247 // code enum are defined in ui/events/keycodes/dom4/keycode_converter_data.h .
248 int domCode; 248 int domCode;
249 249
250 // The DOM key enum of the key pressed as passed by the embedder. DOM
Wez 2015/03/04 23:00:26 This (and the above domCode field) are embedder en
Habib Virji 2015/03/09 15:14:27 As previously stated, it was added as rbyers sugge
Rick Byers 2015/04/20 19:49:46 I don't have a strong preference. It's not like t
Habib Virji 2015/04/29 16:00:50 @wez: Do you have a suggestion on this?
Rick Byers 2015/04/29 17:34:26 Since we haven't heard from wez@ on this yet, I su
251 // key enum are defined in ui/events/keycodes/dom3/dom_key_data.h
252 int domKey;
253
250 // This identifies whether this event was tagged by the system as being 254 // This identifies whether this event was tagged by the system as being
251 // a "system key" event (see 255 // a "system key" event (see
252 // http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx for 256 // http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx for
253 // details). Other platforms don't have this concept, but it's just 257 // details). Other platforms don't have this concept, but it's just
254 // easier to leave it always false than ifdef. 258 // easier to leave it always false than ifdef.
255 bool isSystemKey; 259 bool isSystemKey;
256 260
257 // |text| is the text generated by this keystroke. |unmodifiedText| is 261 // |text| is the text generated by this keystroke. |unmodifiedText| is
258 // |text|, but unmodified by an concurrently-held modifiers (except 262 // |text|, but unmodified by an concurrently-held modifiers (except
259 // shift). This is useful for working out shortcut keys. Linux and 263 // shift). This is useful for working out shortcut keys. Linux and
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 , causesScrollingIfUncanceled(false) 530 , causesScrollingIfUncanceled(false)
527 { 531 {
528 } 532 }
529 }; 533 };
530 534
531 #pragma pack(pop) 535 #pragma pack(pop)
532 536
533 } // namespace blink 537 } // namespace blink
534 538
535 #endif 539 #endif
OLDNEW
« public/platform/Platform.h ('K') | « public/platform/Platform.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698