Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: public/platform/Platform.h

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated global-interface-listing as test were failing due to addition of the key Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index 8bfed7888c95c1943322a3bddf4762cd7429e32e..81ccf13ae72df1d0408797fac3c7100480b69551 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -638,6 +638,18 @@ public:
// Returns 0, if DOM code enum is not found.
virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }
+ // This method converts from the supplied DOM |key| enum to the
Wez 2015/05/06 01:32:13 Suggest: "... from the embedder-supplied |domKey|
+ // corresponding DOM |key| string value for the key pressed. |domKey| values are
Wez 2015/05/06 01:32:13 nit: Remove "for the key pressed" - the call accep
+ // based on the value defined in ui/events/keycodes/dom3/dom_key_data.h.
Wez 2015/05/06 01:32:13 Reword: "The DOM |key| enum <-> string mappings fo
+ // Returns empty string, if DOM key value is not found.
Wez 2015/05/06 01:32:13 nit: No need for comma between "string" and "if".
+ virtual WebString domKeyStringFromEnum(int domKey) { return WebString(); }
+
+ // This method converts from the suppled DOM |key| value to the
+ // embedder's DOM |key| enum for the key pressed. |keyString| is defined in
Wez 2015/05/06 01:32:13 Suggest: "... to the embedder's corresponding enum
+ // ui/events/keycodes/dom3/dom_key_data.h.
+ // Returns 0 if DOM key enum is not found.
Wez 2015/05/06 01:32:13 nit: Suggest "Returns 0 if |keyString| is not reco
+ virtual int domKeyEnumFromString(const WebString& keyString) { return 0; }
+
// Quota -----------------------------------------------------------
// Queries the storage partition's storage usage and quota information.

Powered by Google App Engine
This is Rietveld 408576698