Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: public/platform/Platform.h

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated global-interface-listing as test were failing due to addition of the key Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 // based on the value defined in ui/events/keycodes/dom4/keycode_converter_d ata.h. 631 // based on the value defined in ui/events/keycodes/dom4/keycode_converter_d ata.h.
632 // Returns null string, if DOM code value is not found. 632 // Returns null string, if DOM code value is not found.
633 virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); } 633 virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); }
634 634
635 // This method converts from the suppled DOM code value to the 635 // This method converts from the suppled DOM code value to the
636 // embedder's DOM code enum for the key pressed. |codeString| is defined in 636 // embedder's DOM code enum for the key pressed. |codeString| is defined in
637 // ui/events/keycodes/dom4/keycode_converter_data.h. 637 // ui/events/keycodes/dom4/keycode_converter_data.h.
638 // Returns 0, if DOM code enum is not found. 638 // Returns 0, if DOM code enum is not found.
639 virtual int domEnumFromCodeString(const WebString& codeString) { return 0; } 639 virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }
640 640
641 // This method converts from the supplied DOM |key| enum to the
Wez 2015/05/06 01:32:13 Suggest: "... from the embedder-supplied |domKey|
642 // corresponding DOM |key| string value for the key pressed. |domKey| values are
Wez 2015/05/06 01:32:13 nit: Remove "for the key pressed" - the call accep
643 // based on the value defined in ui/events/keycodes/dom3/dom_key_data.h.
Wez 2015/05/06 01:32:13 Reword: "The DOM |key| enum <-> string mappings fo
644 // Returns empty string, if DOM key value is not found.
Wez 2015/05/06 01:32:13 nit: No need for comma between "string" and "if".
645 virtual WebString domKeyStringFromEnum(int domKey) { return WebString(); }
646
647 // This method converts from the suppled DOM |key| value to the
648 // embedder's DOM |key| enum for the key pressed. |keyString| is defined in
Wez 2015/05/06 01:32:13 Suggest: "... to the embedder's corresponding enum
649 // ui/events/keycodes/dom3/dom_key_data.h.
650 // Returns 0 if DOM key enum is not found.
Wez 2015/05/06 01:32:13 nit: Suggest "Returns 0 if |keyString| is not reco
651 virtual int domKeyEnumFromString(const WebString& keyString) { return 0; }
652
641 // Quota ----------------------------------------------------------- 653 // Quota -----------------------------------------------------------
642 654
643 // Queries the storage partition's storage usage and quota information. 655 // Queries the storage partition's storage usage and quota information.
644 // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called 656 // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called
645 // with the current usage and quota information for the partition. When 657 // with the current usage and quota information for the partition. When
646 // an error occurs WebStorageQuotaCallbacks::didFail is called with an 658 // an error occurs WebStorageQuotaCallbacks::didFail is called with an
647 // error code. 659 // error code.
648 virtual void queryStorageUsageAndQuota( 660 virtual void queryStorageUsageAndQuota(
649 const WebURL& storagePartition, 661 const WebURL& storagePartition,
650 WebStorageQuotaType, 662 WebStorageQuotaType,
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 protected: 705 protected:
694 BLINK_PLATFORM_EXPORT Platform(); 706 BLINK_PLATFORM_EXPORT Platform();
695 virtual ~Platform() { } 707 virtual ~Platform() { }
696 708
697 WebThread* m_mainThread; 709 WebThread* m_mainThread;
698 }; 710 };
699 711
700 } // namespace blink 712 } // namespace blink
701 713
702 #endif 714 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698