Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933153003: Add some image loading layout tests for Web Notifications. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add some image loading layout tests for Web Notifications. These layout tests will exercise the image loading routines that exist to make sure the icon is available prior to displaying the notification. BUG=458640 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190469

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -60 lines) Patch
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow-404.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html View 2 chunks +15 lines, -15 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-abort.html View 1 chunk +41 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect.html View 2 chunks +15 lines, -15 lines 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow.html View 1 2 2 chunks +15 lines, -15 lines 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html View 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Beverloo
+mvanouwerkerk, mlamouri To be landed after the refactoring patch: https://codereview.chromium.org/939513002/
5 years, 10 months ago (2015-02-18 18:28:31 UTC) #2
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/933153003/diff/1/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html File LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html (right): https://codereview.chromium.org/933153003/diff/1/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html#newcode22 LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html:22: assert_inherits(info.registration, 'showNotification', 'showNotification() must be exposed.'); Do you ...
5 years, 10 months ago (2015-02-18 20:38:20 UTC) #3
Peter Beverloo
Thanks for the review. https://codereview.chromium.org/933153003/diff/1/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html File LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html (right): https://codereview.chromium.org/933153003/diff/1/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html#newcode22 LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-404.html:22: assert_inherits(info.registration, 'showNotification', 'showNotification() must be ...
5 years, 10 months ago (2015-02-18 20:48:23 UTC) #5
Michael van Ouwerkerk
lgtm with nits, and a question https://codereview.chromium.org/933153003/diff/20001/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html File LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html (right): https://codereview.chromium.org/933153003/diff/20001/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html#newcode4 LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html:4: <title>Notifications: Showing a ...
5 years, 10 months ago (2015-02-19 11:41:46 UTC) #7
Peter Beverloo
https://codereview.chromium.org/933153003/diff/20001/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html File LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html (right): https://codereview.chromium.org/933153003/diff/20001/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html#newcode4 LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-slow.html:4: <title>Notifications: Showing a notification with an image that 404s.</title> ...
5 years, 10 months ago (2015-02-19 12:03:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933153003/40001
5 years, 10 months ago (2015-02-19 12:09:49 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 13:55:59 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190469

Powered by Google App Engine
This is Rietveld 408576698