Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html

Issue 933153003: Add some image loading layout tests for Web Notifications. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html
diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-no-permission.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html
similarity index 51%
copy from LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-no-permission.html
copy to LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html
index 3abbced552d460ab6eb9861f886956ca44775914..46d5d20a166e770bacfceebe5b31a0fbc265fa5f 100644
--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-no-permission.html
+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow-404.html
@@ -1,7 +1,7 @@
<!doctype html>
<html>
<head>
- <title>Notifications: ServiceWorkerRegistration.showNotification().</title>
+ <title>Notifications: Showing a notification with an image that 404s after a slow redirect.</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<script src="../serviceworker/resources/test-helpers.js"></script>
@@ -9,41 +9,41 @@
</head>
<body>
<script>
- // Tests that the showNotification() function when used in a Service Worker
- // rejects when no permission has been granted. This test requires the test runner.
+ // Tests that showing a notification with an image that creates a 404 response
+ // after a slow redirect works properly, and does not block the actual display of it.
async_test(function(test) {
- var scope = 'resources/scope/serviceworkerregistration-service-worker-click',
+ var scope = 'resources/scope/' + location.pathname,
script = 'resources/instrumentation-service-worker.js';
- testRunner.grantWebNotificationPermission(location.origin, false);
- getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) {
- // (1) Tell the Service Worker to display a Web Notification.
- workerInfo.port.postMessage({
+ testRunner.grantWebNotificationPermission(location.origin, true);
+ getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(info) {
+ // (1) Display a Web Notification through the Service Worker with
+ // an image that 404s after a 200ms redirect to load.
+ info.port.postMessage({
command: 'show',
title: 'My Notification',
- options: { body: 'Hello, world!' }
+ options: { body: 'Hello, world!',
+ icon: '/resources/slow-image.php?redirect_name=not_there.png&mimeType=image/png&sleep=200' }
});
- workerInfo.port.addEventListener('message', function(event) {
+ info.port.addEventListener('message', function(event) {
if (typeof event.data != 'object' || !event.data.command) {
assert_unreached('Invalid message from the Service Worker.');
return;
}
// (2) Listen for confirmation from the Service Worker that the
- // notification could not be displayed because of a permission error.
+ // notification could be displayed as expected.
assert_equals(event.data.command, 'show');
-
- assert_false(event.data.success);
- assert_equals(event.data.message, 'No notification permission has been granted for this origin.');
+ assert_true(event.data.success);
test.done();
});
}).catch(unreached_rejection(test));
- }, 'showNotification() must reject if no Web Notification permission has been granted.');
+ }, 'Displaying a notification with an image that 404s after a slow redirect still resolves the promise.');
</script>
</body>
</html>
« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-slow.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698