Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Issue 933103002: Revert of Add pretty printing for rappor.xml (Closed)

Created:
5 years, 10 months ago by falken
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add pretty printing for rappor.xml (patchset #4 id:60001 of https://codereview.chromium.org/925753002/) Reason for revert: This breaks extract_actions.py. $ tools/metrics/actions/extract_actions.py Traceback (most recent call last): File "tools/metrics/actions/extract_actions.py", line 852, in <module> sys.exit(main(sys.argv)) File "tools/metrics/actions/extract_actions.py", line 848, in main presubmit_util.DoPresubmitMain(argv, 'actions.xml', 'actions.old.xml', NameError: global name 'presubmit_util' is not defined Original issue's description: > Add pretty printing for rappor.xml > > BUG=381380 > > Committed: https://crrev.com/3edb8729b72e1b1c77cda6d2431094079d2a8fad > Cr-Commit-Position: refs/heads/master@{#316634} TBR=asvitkine@chromium.org,holte@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=381380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -647 lines) Patch
M tools/metrics/actions/extract_actions.py View 2 chunks +32 lines, -7 lines 0 comments Download
D tools/metrics/common/models.py View 1 chunk +0 lines, -214 lines 0 comments Download
D tools/metrics/common/presubmit_util.py View 1 chunk +0 lines, -79 lines 0 comments Download
M tools/metrics/histograms/pretty_print.py View 2 chunks +55 lines, -4 lines 0 comments Download
D tools/metrics/rappor/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/metrics/rappor/PRESUBMIT.py View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/metrics/rappor/pretty_print.py View 1 chunk +0 lines, -167 lines 0 comments Download
D tools/metrics/rappor/pretty_print_test.py View 1 chunk +0 lines, -82 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 4 chunks +75 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
falken
Created Revert of Add pretty printing for rappor.xml
5 years, 10 months ago (2015-02-18 02:20:42 UTC) #1
falken
5 years, 10 months ago (2015-02-18 02:37:49 UTC) #3
Message was sent while issue was closed.
On 2015/02/18 02:20:42, falken wrote:
> Created Revert of Add pretty printing for rappor.xml

Closed as a fix is in the CQ.

Powered by Google App Engine
This is Rietveld 408576698