Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: tools/metrics/rappor/pretty_print_test.py

Issue 933103002: Revert of Add pretty printing for rappor.xml (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/rappor/pretty_print.py ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/rappor/pretty_print_test.py
diff --git a/tools/metrics/rappor/pretty_print_test.py b/tools/metrics/rappor/pretty_print_test.py
deleted file mode 100755
index 428158a9ccf9c883ca6cc75784f8dcdfc1faaeb9..0000000000000000000000000000000000000000
--- a/tools/metrics/rappor/pretty_print_test.py
+++ /dev/null
@@ -1,82 +0,0 @@
-#!/usr/bin/env python
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import unittest
-
-import pretty_print
-
-
-PRETTY_XML = """
-<!-- Comment1 -->
-
-<rappor-configuration>
-<!-- Comment2 -->
-
-<rappor-parameter-types>
-<!-- Comment3 -->
-
-<rappor-parameters name="TEST_RAPPOR_TYPE">
- <summary>
- Fake type for tests.
- </summary>
- <parameters num-cohorts="128" bytes="1" hash-functions="2" fake-prob="0.5"
- fake-one-prob="0.5" one-coin-prob="0.75" zero-coin-prob="0.25"
- reporting-level="COARSE"/>
-</rappor-parameters>
-
-</rappor-parameter-types>
-
-<rappor-metrics>
-<!-- Comment4 -->
-
-<rappor-metric name="Test.Rappor.Metric" type="TEST_RAPPOR_TYPE">
- <owner>user1@chromium.org</owner>
- <owner>user2@chromium.org</owner>
- <summary>
- A fake metric summary.
- </summary>
-</rappor-metric>
-
-</rappor-metrics>
-
-</rappor-configuration>
-""".strip()
-
-BASIC_METRIC = {
- 'comments': [],
- 'name': 'Test.Rappor.Metric',
- 'type': 'TEST_RAPPOR_TYPE',
- 'owners': ['user1@chromium.org', 'user2@chromium.org'],
- 'summary': 'A fake metric summary.',
-}
-
-
-class ActionXmlTest(unittest.TestCase):
-
- def testIsPretty(self):
- result = pretty_print.UpdateXML(PRETTY_XML)
- self.assertEqual(PRETTY_XML, result)
-
- def testParsing(self):
- comments, config = pretty_print.RAPPOR_XML_TYPE.Parse(PRETTY_XML)
- self.assertEqual(BASIC_METRIC, config['metrics']['metrics'][0])
- self.assertEqual(set(['TEST_RAPPOR_TYPE']),
- pretty_print.GetTypeNames(config))
-
- def testMissingOwners(self):
- self.assertFalse(pretty_print.HasMissingOwners([BASIC_METRIC]))
- no_owners = BASIC_METRIC.copy()
- no_owners['owners'] = []
- self.assertTrue(pretty_print.HasMissingOwners([no_owners]))
-
- def testInvalidTypes(self):
- self.assertFalse(pretty_print.HasInvalidTypes(
- set(['TEST_RAPPOR_TYPE']), [BASIC_METRIC]))
- self.assertTrue(pretty_print.HasInvalidTypes(
- set(['OTHER_TYPE']), [BASIC_METRIC]))
-
-
-if __name__ == '__main__':
- unittest.main()
« no previous file with comments | « tools/metrics/rappor/pretty_print.py ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698