Ensure streams aren't intercepted unless their associated plugin is enabled

Ensure streams aren't intercepted unless their associated plugin is enabled

Previously streams would be intercepted even if the MimeHandlerView plugin
associated with them was disabled which would prevent the resource
from being download if a plugin wasn't being enabled to handle it.

BUG=459383
Committed: https://crrev.com/553cec8b3c449a02a69a1663f5fb077f3abefba2
Cr-Commit-Position: refs/heads/master@{#317673}

[raymes, 2015-02-18 01:46:57]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2015-02-18 03:32:16]

LGTM

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:217:
bool found = content::PluginService::GetInstance()->GetPluginInfoByPath(
if (!content::PluginService::GetInstance()->GetPluginInfoByPath(

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:231:
bool enabled = PluginPrefs::GetForProfile(Profile::FromBrowserContext(
if (!PluginPrefs::GetForProfile(Profile::FromBrowserContext(

[raymes, 2015-02-18 03:57:58]

New patchsets have been uploaded after l-g-t-m from sammc@chromium.org

[raymes, 2015-02-18 04:03:03]

raymes@chromium.org changed reviewers:
+ thestig@chromium.org

[raymes, 2015-02-18 04:03:04]

+thestig@chromium.org for OWNERS (I don't know of anyone better for this but if
you do please feel free to redirect! :)

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:217:
bool found = content::PluginService::GetInstance()->GetPluginInfoByPath(
On 2015/02/18 03:32:15, Sam McNally wrote:
> if (!content::PluginService::GetInstance()->GetPluginInfoByPath(

Done.

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:231:
bool enabled = PluginPrefs::GetForProfile(Profile::FromBrowserContext(
On 2015/02/18 03:32:15, Sam McNally wrote:
> if (!PluginPrefs::GetForProfile(Profile::FromBrowserContext(

Done.

https://codereview.chromium.org/933093002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:231:
bool enabled = PluginPrefs::GetForProfile(Profile::FromBrowserContext(
On 2015/02/18 03:32:15, Sam McNally wrote:
> if (!PluginPrefs::GetForProfile(Profile::FromBrowserContext(

Done.

[Lei Zhang, 2015-02-18 04:24:18]

lgtm

https://codereview.chromium.org/933093002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/933093002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:233: if
(!PluginPrefs::GetForProfile(Profile::FromBrowserContext(
You can just return the IsPluginEnabled() result here.

[raymes, 2015-02-18 21:24:24]

New patchsets have been uploaded after l-g-t-m from thestig@chromium.org

[raymes, 2015-02-18 21:24:27]

https://codereview.chromium.org/933093002/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/933093002/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:233: if
(!PluginPrefs::GetForProfile(Profile::FromBrowserContext(
On 2015/02/18 04:24:18, Lei Zhang (Soon to be OOO) wrote:
> You can just return the IsPluginEnabled() result here.

Done.

[raymes, 2015-02-18 21:24:32]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-02-18 21:25:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/933093002/40001

[commit-bot: I haz the power, 2015-02-18 22:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 22:39:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2015-02-23 00:17:57]

Please take another look. I had to rework this patch because the other one
required a thread-hop. 

I have a better fix in mind (see the referenced bug) but this is less risky in
the short-term (and this needs to be merged to M42 branch now).

[Sam McNally, 2015-02-23 00:38:35]

lgtm

https://codereview.chromium.org/933093002/diff/60001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/933093002/diff/60001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:223:
url, mime_type, true, &plugins, nullptr);
This looks like it can fit on the previous line.

https://codereview.chromium.org/933093002/diff/60001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:226:
for (size_t i = 0; i < plugins.size(); ++i) {
for-each loop?

[raymes, 2015-02-23 02:25:40]

New patchsets have been uploaded after l-g-t-m from sammc@chromium.org

[raymes, 2015-02-23 02:26:13]

https://codereview.chromium.org/933093002/diff/60001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/933093002/diff/60001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:223:
url, mime_type, true, &plugins, nullptr);
On 2015/02/23 00:38:35, Sam McNally wrote:
> This looks like it can fit on the previous line.

Done.

https://codereview.chromium.org/933093002/diff/60001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:226:
for (size_t i = 0; i < plugins.size(); ++i) {
On 2015/02/23 00:38:34, Sam McNally wrote:
> for-each loop?

Done.

[raymes, 2015-02-23 02:29:36]

raymes@chromium.org changed reviewers:
+ jam@chromium.org

[raymes, 2015-02-23 02:29:37]

+jam for OWNERS
thestig@ is out and jochen@ is slow.

[jam, 2015-02-23 16:54:27]

lgtm

[raymes, 2015-02-23 21:50:57]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:51:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/933093002/80001

[commit-bot: I haz the power, 2015-02-23 23:02:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-23 23:03:39]

Patchset 5 (id:??) landed as
https://crrev.com/553cec8b3c449a02a69a1663f5fb077f3abefba2
Cr-Commit-Position: refs/heads/master@{#317673}