Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932703006: Enforce HTTPS URLs to show app banners. (Closed)

Created:
5 years, 10 months ago by Ted C
Modified:
5 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce HTTPS URLs to show app banners. BUG=459773 Committed: https://crrev.com/6f401eef9e676bb2b6c7f674cd712b69cf321784 Cr-Commit-Position: refs/heads/master@{#317116}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/banners/app_banner_settings_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Ted C
PTAL
5 years, 10 months ago (2015-02-19 18:56:19 UTC) #2
gone
lgtm
5 years, 10 months ago (2015-02-19 18:58:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932703006/1
5 years, 10 months ago (2015-02-19 19:02:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/60506) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-19 19:06:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932703006/20001
5 years, 10 months ago (2015-02-19 19:38:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 20:02:44 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 20:03:49 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6f401eef9e676bb2b6c7f674cd712b69cf321784
Cr-Commit-Position: refs/heads/master@{#317116}

Powered by Google App Engine
This is Rietveld 408576698