Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 932703006: Enforce HTTPS URLs to show app banners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index 934765f45c93c2272815b1d7206815a14d1aee5b..1e17f7cb64a742bd021f36862b4513673003cf22 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -140,6 +140,12 @@ public class AppBannerManager extends EmptyTabObserver {
nativeSetTimeDeltaForTesting(days);
}
+ /** Disables the HTTPS scheme requirement for testing. */
+ @VisibleForTesting
+ static void disableSecureSchemeCheckForTesting() {
+ nativeDisableSecureSchemeCheckForTesting();
+ }
+
/** Returns whether a BitmapFetcher is actively retrieving an app icon. */
@VisibleForTesting
public boolean isFetcherActiveForTesting() {
@@ -156,5 +162,6 @@ public class AppBannerManager extends EmptyTabObserver {
// Testing methods.
private static native void nativeSetTimeDeltaForTesting(int days);
+ private static native void nativeDisableSecureSchemeCheckForTesting();
private native boolean nativeIsFetcherActive(long nativeAppBannerManager);
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698