Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932533003: Remove the holder_ field from LookupResult (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the holder_ field from LookupResult BUG= Committed: https://crrev.com/6e56fd60e09875dfad989b0fcc9fa7af5a7ea886 Cr-Commit-Position: refs/heads/master@{#26717}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -27 lines) Patch
M src/hydrogen.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -8 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -7 lines 0 comments Download
M src/property.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/property.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-17 15:09:25 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-17 15:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932533003/1
5 years, 10 months ago (2015-02-17 15:14:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/2037)
5 years, 10 months ago (2015-02-17 16:17:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932533003/1
5 years, 10 months ago (2015-02-17 16:23:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/2052)
5 years, 10 months ago (2015-02-17 16:56:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932533003/1
5 years, 10 months ago (2015-02-18 10:10:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/2069) v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, ...
5 years, 10 months ago (2015-02-18 10:13:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932533003/20001
5 years, 10 months ago (2015-02-18 10:59:05 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 11:21:17 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 11:21:30 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6e56fd60e09875dfad989b0fcc9fa7af5a7ea886
Cr-Commit-Position: refs/heads/master@{#26717}

Powered by Google App Engine
This is Rietveld 408576698