Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: src/property.h

Issue 932533003: Remove the holder_ field from LookupResult (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/property.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property.h
diff --git a/src/property.h b/src/property.h
index dd2ede880741873094a4ad5e63f9bbe506ee6feb..79abca04c9d50f4e6c160b0893f9537bf758f418 100644
--- a/src/property.h
+++ b/src/property.h
@@ -110,7 +110,6 @@ class LookupResult FINAL BASE_EMBEDDED {
: isolate_(isolate),
next_(isolate->top_lookup_result()),
lookup_type_(NOT_FOUND),
- holder_(NULL),
transition_(NULL),
details_(NONE, DATA, Representation::None()) {
isolate->set_top_lookup_result(this);
@@ -123,26 +122,23 @@ class LookupResult FINAL BASE_EMBEDDED {
Isolate* isolate() const { return isolate_; }
- void DescriptorResult(JSObject* holder, PropertyDetails details, int number) {
+ void DescriptorResult(PropertyDetails details, int number) {
lookup_type_ = DESCRIPTOR_TYPE;
- holder_ = holder;
transition_ = NULL;
details_ = details;
number_ = number;
}
- void TransitionResult(JSObject* holder, Map* target) {
+ void TransitionResult(Map* target) {
lookup_type_ = TRANSITION_TYPE;
number_ = target->LastAdded();
details_ = target->instance_descriptors()->GetDetails(number_);
- holder_ = holder;
transition_ = target;
}
void NotFound() {
lookup_type_ = NOT_FOUND;
details_ = PropertyDetails(NONE, DATA, 0);
- holder_ = NULL;
transition_ = NULL;
}
@@ -232,7 +228,6 @@ class LookupResult FINAL BASE_EMBEDDED {
// Where did we find the result;
enum { NOT_FOUND, DESCRIPTOR_TYPE, TRANSITION_TYPE } lookup_type_;
- JSReceiver* holder_;
Map* transition_;
int number_;
PropertyDetails details_;
« no previous file with comments | « src/objects-inl.h ('k') | src/property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698