Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: tests/standalone/standalone.status

Issue 932493004: Move more tests to SkipByDesign (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/standalone.status
diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status
index 9606217614852a9ff094845f4bf44e41f5b7cde4..8cccb17136f781b069a480541b021d5b8bc798b2 100644
--- a/tests/standalone/standalone.status
+++ b/tests/standalone/standalone.status
@@ -39,14 +39,14 @@ io/socket_many_connections_test: Skip
[ $compiler == none && ($runtime == drt || $runtime == dartium || $runtime == ContentShellOnAndroid) ]
Bill Hesse 2015/02/23 08:53:25 Should this line instead say "compiler = none && b
kevmoo 2015/02/23 21:30:18 Maybe? We'll have to wait until the linter work to
typed_array_test: Fail # Issue 13921
typed_array_int64_uint64_test: Fail # Issue 13921
-typed_data_isolate_test: Skip # This test uses dart:io
-io/*: Skip # Don't run tests using dart:io in the browser
-package/*: Skip # Do not run those in Dartium.
-debugger/*: Skip # Do not run standalone debugger tests in browser.
+typed_data_isolate_test: SkipByDesign # This test uses dart:io
+io/*: SkipByDesign # Don't run tests using dart:io in the browser
Bill Hesse 2015/02/23 08:53:25 Make all "dart:io" comments the same.
kevmoo 2015/02/23 21:30:17 Done.
+package/*: SkipByDesign # Do not run those in Dartium.
Bill Hesse 2015/02/23 08:53:25 Why don't we run package tests in Dartium? Isn't
kevmoo 2015/02/23 21:30:17 Rolling back the contentious ones – should triage
+debugger/*: SkipByDesign # Do not run standalone debugger tests in browser.
coverage_test: Skip
full_coverage_test: Skip
http_launch_test: Skip
-vmservice/*: Skip # Do not run standalone vm service tests in browser.
+vmservice/*: SkipByDesign # Do not run standalone vm service tests in browser.
issue14236_test: Skip # Issue 14236 Script snapshots do not work in the browser.
javascript_compatibility_errors_test: Skip
javascript_compatibility_warnings_test: Skip
@@ -65,29 +65,29 @@ io/process_exit_negative_test: Skip
[ $compiler == dart2js ]
number_identity_test: Skip # Bigints and int/double diff. not supported.
-typed_data_test: Skip # dart:typed_data support needed.
-bytedata_test: Skip # dart:typed_data support needed.
-typed_data_view_test: Skip # dart:typed_data support needed.
-typed_data_isolate_test: Skip # dart:typed_data support needed.
-typed_array_int64_uint64_test: Skip # dart:typed_data on dart2js does not support 64-bit ints.
-float_array_test: Skip # dart:typed_data support needed.
-int_array_test: Skip # dart:typed_data support needed.
+typed_data_test: SkipByDesign # dart:typed_data support needed.
Bill Hesse 2015/02/23 08:53:25 I thought we had typed_data on dart2js. Is this j
kevmoo 2015/02/23 21:30:17 Rolling back the contentious ones – should triage
+bytedata_test: SkipByDesign # dart:typed_data support needed.
+typed_data_view_test: SkipByDesign # dart:typed_data support needed.
+typed_data_isolate_test: SkipByDesign # dart:typed_data support needed.
+typed_array_int64_uint64_test: SkipByDesign # dart:typed_data on dart2js does not support 64-bit ints.
+float_array_test: SkipByDesign # dart:typed_data support needed.
+int_array_test: SkipByDesign # dart:typed_data support needed.
io/web_socket_protocol_processor_test: Skip # Importing code with external keyword
-int_array_load_elimination_test: Skip # This is a VM test
+int_array_load_elimination_test: SkipByDesign # This is a VM test
medium_integer_test: RuntimeError, OK # Test fails with JS number semantics: issue 1533.
io/process_exit_negative_test: Fail, OK # relies on a static error that is a warning now.
package/package_isolate_test: Skip # spawnUri does not work in dart2js. See issue 3051
-debugger/*: Skip # Do not run standalone vm debugger tests with dart2js.
+debugger/*: SkipByDesign # Do not run standalone vm debugger tests with dart2js.
full_coverage_test: Skip
-left_shift_bit_and_op_test: Skip # Integers exceed dart2js precision.
-pow_test: Skip # Precision > 53 bits.
-double_smi_comparison_test: Skip # Precision > 53 bits.
+left_shift_bit_and_op_test: SkipByDesign # Integers exceed dart2js precision.
Bill Hesse 2015/02/23 08:53:25 Again, if we have an issue for this, I think it sh
kevmoo 2015/02/23 21:30:18 Acknowledged.
+pow_test: SkipByDesign # Precision > 53 bits.
Bill Hesse 2015/02/23 08:53:25 Just say the int/double issue here, if there isn't
kevmoo 2015/02/23 21:30:17 Acknowledged.
+double_smi_comparison_test: SkipByDesign # Precision > 53 bits.
http_launch_test: Skip
javascript_int_overflow_test: Skip
Bill Hesse 2015/02/23 08:53:25 Probably the same issue.
kevmoo 2015/02/23 21:30:17 Acknowledged.
javascript_int_overflow_literal_test: Skip
oom_error_stacktrace_test: RuntimeError, OK # (OOM on JS may produce a stacktrace).
-vmservice/*: Skip # Do not run standalone vm service tests with dart2js.
-issue14236_test: Skip # dart2js does not deal with Script snapshots.
+vmservice/*: SkipByDesign # Do not run standalone vm service tests with dart2js.
Bill Hesse 2015/02/23 08:53:25 Should we have a !$standalone variable and section
kevmoo 2015/02/23 21:30:17 Acknowledged.
+issue14236_test: SkipByDesign # dart2js does not deal with Script snapshots.
javascript_compatibility_errors_test: Skip
javascript_compatibility_warnings_test: Skip
unboxed_int_converter_test: Skip
Bill Hesse 2015/02/23 08:53:25 Probably int/double issue.
kevmoo 2015/02/23 21:30:17 Acknowledged.
« tests/lib/lib.status ('K') | « tests/lib/lib.status ('k') | tests/try/try.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698