Move more tests to SkipByDesign

tests/standalone/standalone.status

 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # WARNING:
 # Tests using the multitest feature where failure is expected should *also* be
 # listed in tests/lib/analyzer/analyze_tests.status without the "standalone"
 # prefix.
 
 package/invalid_uri_test: Fail, OK # CompileTimeErrors intentionally
@@ skipping 18 matching lines @@
 # checked mode with no benefit. Skip.
 io/file_fuzz_test: Skip
 io/directory_fuzz_test: Skip
 
 [ $runtime == vm && $system == macos ]
 # This test fails with "Too many open files" on the Mac OS buildbot.
 # This is expected as MacOS by default runs with a very low number
 # of allowed open files ('ulimit -n' says something like 256).
 io/socket_many_connections_test: Skip
 
 [ $compiler == none && ($runtime == drt || $runtime == dartium || $runtime == ContentShellOnAndroid) ]

[Bill Hesse, 2015/02/23 08:53:25]

Should this line instead say "compiler = none && browser"?

[kevmoo, 2015/02/23 21:30:18]

Maybe? We'll have to wait until the linter work to dig in on these

 typed_array_test: Fail # Issue 13921
 typed_array_int64_uint64_test: Fail # Issue 13921
-typed_data_isolate_test: Skip # This test uses dart:io
-io/*: Skip # Don't run tests using dart:io in the browser
-package/*: Skip # Do not run those in Dartium.
-debugger/*: Skip # Do not run standalone debugger tests in browser.
+typed_data_isolate_test: SkipByDesign # This test uses dart:io
+io/*: SkipByDesign # Don't run tests using dart:io in the browser

[Bill Hesse, 2015/02/23 08:53:25]

Make all "dart:io" comments the same.

[kevmoo, 2015/02/23 21:30:17]

Done.

+package/*: SkipByDesign # Do not run those in Dartium.

[Bill Hesse, 2015/02/23 08:53:25]

Why don't we run package tests in Dartium?  Isn't this a time issue, rather than
a design issue? 

[kevmoo, 2015/02/23 21:30:17]

Rolling back the contentious ones – should triage later

+debugger/*: SkipByDesign # Do not run standalone debugger tests in browser.
 coverage_test: Skip
 full_coverage_test: Skip
 http_launch_test: Skip
-vmservice/*: Skip # Do not run standalone vm service tests in browser.
+vmservice/*: SkipByDesign # Do not run standalone vm service tests in browser.
 issue14236_test: Skip # Issue 14236 Script snapshots do not work in the browser.
 javascript_compatibility_errors_test: Skip
 javascript_compatibility_warnings_test: Skip
 oom_error_stacktrace_test: Skip
 out_of_memory_test: Skip
 
 [ $compiler == dartanalyzer || $compiler == dart2analyzer ]
 javascript_int_overflow_literal_test/01: Fail, OK
 issue14236_test: Skip # Analyzer can't handle Script snapshots.
 
 # test issue https://code.google.com/p/dart/issues/detail?id=11518
 io/file_constructor_test: fail
 
 # This is runtime test.
 io/process_exit_negative_test: Skip
 
 [ $compiler == dart2js ]
 number_identity_test: Skip # Bigints and int/double diff. not supported.
-typed_data_test: Skip # dart:typed_data support needed.
-bytedata_test: Skip # dart:typed_data support needed.
-typed_data_view_test: Skip # dart:typed_data support needed.
-typed_data_isolate_test: Skip # dart:typed_data support needed.
-typed_array_int64_uint64_test: Skip # dart:typed_data on dart2js does not support 64-bit ints.
-float_array_test: Skip # dart:typed_data support needed.
-int_array_test: Skip  # dart:typed_data support needed.
+typed_data_test: SkipByDesign # dart:typed_data support needed.

[Bill Hesse, 2015/02/23 08:53:25]

I thought we had typed_data on dart2js.  Is this just incomplete support, so
this is actually an issue, or is it really not supported.  There are typed
arrays on the web.

[kevmoo, 2015/02/23 21:30:17]

Rolling back the contentious ones – should triage later

+bytedata_test: SkipByDesign # dart:typed_data support needed.
+typed_data_view_test: SkipByDesign # dart:typed_data support needed.
+typed_data_isolate_test: SkipByDesign # dart:typed_data support needed.
+typed_array_int64_uint64_test: SkipByDesign # dart:typed_data on dart2js does not support 64-bit ints.
+float_array_test: SkipByDesign # dart:typed_data support needed.
+int_array_test: SkipByDesign  # dart:typed_data support needed.
 io/web_socket_protocol_processor_test: Skip  # Importing code with external keyword
-int_array_load_elimination_test: Skip  # This is a VM test
+int_array_load_elimination_test: SkipByDesign  # This is a VM test
 medium_integer_test: RuntimeError, OK # Test fails with JS number semantics: issue 1533.
 io/process_exit_negative_test: Fail, OK # relies on a static error that is a warning now.
 package/package_isolate_test: Skip # spawnUri does not work in dart2js. See issue 3051
-debugger/*: Skip # Do not run standalone vm debugger tests with dart2js.
+debugger/*: SkipByDesign # Do not run standalone vm debugger tests with dart2js.
 full_coverage_test: Skip
-left_shift_bit_and_op_test: Skip # Integers exceed dart2js precision.
-pow_test: Skip # Precision > 53 bits.
-double_smi_comparison_test: Skip # Precision > 53 bits.
+left_shift_bit_and_op_test: SkipByDesign # Integers exceed dart2js precision.

[Bill Hesse, 2015/02/23 08:53:25]

Again, if we have an issue for this, I think it shouldn't be SkipByDesign, but
Skip with an issue.  Or is this not the plan.  Is Skip due to an unfixable issue
the same as Skip due to the inherent properties of the platform?

[kevmoo, 2015/02/23 21:30:18]

Acknowledged.

+pow_test: SkipByDesign # Precision > 53 bits.

[Bill Hesse, 2015/02/23 08:53:25]

Just say the int/double issue here, if there isn't a separate precision issue. 
Make the comments the same for all 3 tests.

[kevmoo, 2015/02/23 21:30:17]

Acknowledged.

+double_smi_comparison_test: SkipByDesign # Precision > 53 bits.
 http_launch_test: Skip
 javascript_int_overflow_test: Skip

[Bill Hesse, 2015/02/23 08:53:25]

Probably the same issue.

[kevmoo, 2015/02/23 21:30:17]

Acknowledged.

 javascript_int_overflow_literal_test: Skip
 oom_error_stacktrace_test: RuntimeError, OK # (OOM on JS may produce a stacktrace).
-vmservice/*: Skip # Do not run standalone vm service tests with dart2js.
-issue14236_test: Skip # dart2js does not deal with Script snapshots.
+vmservice/*: SkipByDesign # Do not run standalone vm service tests with dart2js.

[Bill Hesse, 2015/02/23 08:53:25]

Should we have a !$standalone variable and section, for things that are skipped
on both Dartium and dart2js?

[kevmoo, 2015/02/23 21:30:17]

Acknowledged.

+issue14236_test: SkipByDesign # dart2js does not deal with Script snapshots.
 javascript_compatibility_errors_test: Skip
 javascript_compatibility_warnings_test: Skip
 unboxed_int_converter_test: Skip

[Bill Hesse, 2015/02/23 08:53:25]

Probably int/double issue.

[kevmoo, 2015/02/23 21:30:17]

Acknowledged.

 pair_location_remapping_test: Skip
 
 [ $compiler == dart2js && $jscl ]
 assert_test: RuntimeError, OK # Assumes unspecified fields on the AssertionError.
 deoptimization_test: RuntimeError, OK # Requires bigint.
 out_of_memory_test: RuntimeError, OK # d8 handles much larger arrays than Dart VM.
 io/arguments_test: CompileTimeError, OK # Cannot pass arguments to d8.
 
 [ $compiler == dart2js && $runtime == none ]
 io/arguments_test: Fail # DartOptions not supported by dart2js, and issue 14200.
@@ skipping 55 matching lines @@
 io/skipping_dart2js_compilations_test: Fail # Issue 19551.
 
 [ $arch != ia32 && $arch != x64 && $arch != simarm && $mode == debug ]
 verified_mem_test: Skip  # Not yet implemented.
 
 [ $runtime == vm && $mode == debug && $builder_tag == asan ]
 full_coverage_test: Skip  # Timeout.
 io/file_lock_test: Skip  # Timeout.
 io/test_runner_test: Skip  # Timeout.
 io/http_client_stays_alive_test: Skip  # Timeout.