Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932333003: Make maxtries for Rietveld configurable (Closed)

Created:
5 years, 10 months ago by Paweł Hajdan Jr.
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Make maxtries for Rietveld configurable R=machenbach TBR=maruel BUG=459855 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294121

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M rietveld.py View 7 chunks +11 lines, -7 lines 4 comments Download

Messages

Total messages: 11 (4 generated)
Paweł Hajdan Jr.
This is needed for https://chromereviews.googleplex.com/151587013/
5 years, 10 months ago (2015-02-19 11:15:00 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/932333003/diff/1/rietveld.py File rietveld.py (right): https://codereview.chromium.org/932333003/diff/1/rietveld.py#newcode603 rietveld.py:603: self._maxtries = 40 or maxtries Hmm, sad that ...
5 years, 10 months ago (2015-02-19 11:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932333003/1
5 years, 10 months ago (2015-02-19 11:25:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294121
5 years, 10 months ago (2015-02-19 11:29:04 UTC) #6
Jens Widell
https://codereview.chromium.org/932333003/diff/1/rietveld.py File rietveld.py (right): https://codereview.chromium.org/932333003/diff/1/rietveld.py#newcode603 rietveld.py:603: self._maxtries = 40 or maxtries This is the same ...
5 years, 10 months ago (2015-02-19 11:32:40 UTC) #8
Michael Achenbach
https://codereview.chromium.org/932333003/diff/1/rietveld.py File rietveld.py (right): https://codereview.chromium.org/932333003/diff/1/rietveld.py#newcode603 rietveld.py:603: self._maxtries = 40 or maxtries Ups, totally missed that. ...
5 years, 10 months ago (2015-02-19 11:33:56 UTC) #9
Paweł Hajdan Jr.
5 years, 10 months ago (2015-02-19 11:49:04 UTC) #11
Message was sent while issue was closed. 
TBR

https://codereview.chromium.org/932333003/diff/1/rietveld.py
File rietveld.py (right):

https://codereview.chromium.org/932333003/diff/1/rietveld.py#newcode603
rietveld.py:603: self._maxtries = 40 or maxtries
On 2015/02/19 11:33:56, Michael Achenbach wrote:
> Ups, totally missed that. Good catch!

Good catch, fixed in https://codereview.chromium.org/933373004/

Thanks!

Powered by Google App Engine
This is Rietveld 408576698