[Win] Revert the profile switcher code from the jumplist.

[Win] Revert the profile switcher code from the jumplist.

This was a failed experiment. The jumplist is way too fragile and finicky
to be a good, long term solution for a fast-profile-switcher (mostly because
it can only display up to 10 profiles).

This code was initially introduced in https://codereview.chromium.org/660813002/
(with a followup CL to fix it), but that CL also introduced some useful
jumplist related metrics, so I'll just manually revert the jumplist bits.

BUG=431392
Committed: https://crrev.com/c1a2d79550785a71188df21e78c87447c63ebc38
Cr-Commit-Position: refs/heads/master@{#317649}

[noms (inactive), 2015-02-17 19:27:02]

noms@chromium.org changed reviewers:
+ tapted@chromium.org

[noms (inactive), 2015-02-17 19:27:03]

Hi Trent,

Remember that time we added a list of Profiles to the Windows jumplist? Well,
here's the CL to remove that code :)

Please take a look. Thanks!

[tapted, 2015-02-18 03:07:19]

Should we also remove switches::kActivateExistingProfileBrowser ?

https://codereview.chromium.org/931853003/diff/1/chrome/browser/jumplist_win.h
File chrome/browser/jumplist_win.h (right):

https://codereview.chromium.org/931853003/diff/1/chrome/browser/jumplist_win....
chrome/browser/jumplist_win.h:26: #include
"content/public/browser/notification_registrar.h"
optinal-nit: The registrar can probably still be forward-declared in the header
(and this moved to .cc) since it's scoped_ptr. But there's so little including
this I doubt it's worthwhile.

https://codereview.chromium.org/931853003/diff/1/chrome/browser/metrics/jumpl...
File chrome/browser/metrics/jumplist_metrics_win.h (left):

https://codereview.chromium.org/931853003/diff/1/chrome/browser/metrics/jumpl...
chrome/browser/metrics/jumplist_metrics_win.h:17: SWITCH_TO_PROFILE,        // A
profile name from the "People" category.
we typically can't remove UMA enums - maybe just add an _UNUSED to the name so
that the buckets do not change

[noms (inactive), 2015-02-19 15:41:35]

https://codereview.chromium.org/931853003/diff/1/chrome/browser/jumplist_win.h
File chrome/browser/jumplist_win.h (right):

https://codereview.chromium.org/931853003/diff/1/chrome/browser/jumplist_win....
chrome/browser/jumplist_win.h:26: #include
"content/public/browser/notification_registrar.h"
On 2015/02/18 03:07:18, tapted wrote:
> optinal-nit: The registrar can probably still be forward-declared in the
header
> (and this moved to .cc) since it's scoped_ptr. But there's so little including
> this I doubt it's worthwhile.

Done.

https://codereview.chromium.org/931853003/diff/1/chrome/browser/metrics/jumpl...
File chrome/browser/metrics/jumplist_metrics_win.h (left):

https://codereview.chromium.org/931853003/diff/1/chrome/browser/metrics/jumpl...
chrome/browser/metrics/jumplist_metrics_win.h:17: SWITCH_TO_PROFILE,        // A
profile name from the "People" category.
On 2015/02/18 03:07:18, tapted wrote:
> we typically can't remove UMA enums - maybe just add an _UNUSED to the name so
> that the buckets do not change

hurrrrr i even wrote the "don't remove entries" comment at the top. >.<

[tapted, 2015-02-19 23:20:18]

lgtm!

[noms, 2015-02-20 18:48:41]

noms@google.com changed reviewers:
+ cpu@chromium.org, noms@google.com, sky@chromium.org

[noms, 2015-02-20 18:48:42]

Adding owners:
+ sky: c/b/ui/startup
+ cpu: c/b/.*/jumplist*, c/common/switch_utils.cc

Thanks!

[sky, 2015-02-20 21:27:20]

LGTM

[noms (inactive), 2015-02-23 14:54:20]

cpu: ping!

[cpu_(ooo_6.6-7.5), 2015-02-23 21:05:06]

lgtm

[noms (inactive), 2015-02-23 21:06:06]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:06:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/931853003/40001

[commit-bot: I haz the power, 2015-02-23 21:11:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-23 21:11:55]

Patchset 3 (id:??) landed as
https://crrev.com/c1a2d79550785a71188df21e78c87447c63ebc38
Cr-Commit-Position: refs/heads/master@{#317649}