Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: chrome/browser/metrics/jumplist_metrics_win.h

Issue 931853003: [Win] Revert the profile switcher code from the jumplist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_ 5 #ifndef CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_
6 #define CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_ 6 #define CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 namespace jumplist { 10 namespace jumplist {
11 11
12 // Enum for counting which category was clicked. 12 // Enum for counting which category was clicked.
13 // Note: UMA histogram enum - don't re-order or remove entries 13 // Note: UMA histogram enum - don't re-order or remove entries
14 enum JumplistCategory { 14 enum JumplistCategory {
15 RECENTLY_CLOSED_URL = 0, // A URL from the "Recently Closed" category. 15 RECENTLY_CLOSED_URL = 0, // A URL from the "Recently Closed" category.
16 MOST_VISITED_URL, // A URL from the "Most Visited" category. 16 MOST_VISITED_URL, // A URL from the "Most Visited" category.
17 SWITCH_TO_PROFILE, // A profile name from the "People" category.
tapted 2015/02/18 03:07:18 we typically can't remove UMA enums - maybe just a
noms (inactive) 2015/02/19 15:41:34 hurrrrr i even wrote the "don't remove entries" co
18 CATEGORY_UNKNOWN, // An invalid category. 17 CATEGORY_UNKNOWN, // An invalid category.
19 NUM_JUMPLIST_CATEGORY_METRICS 18 NUM_JUMPLIST_CATEGORY_METRICS
20 }; 19 };
21 20
22 // Category types that can be logged with the --win-jumplist-action switch. 21 // Category types that can be logged with the --win-jumplist-action switch.
23 extern const char kMostVisitedCategory[]; 22 extern const char kMostVisitedCategory[];
24 extern const char kProfilesCategory[]; 23 extern const char kProfilesCategory[];
25 extern const char kRecentlyClosedCategory[]; 24 extern const char kRecentlyClosedCategory[];
26 25
27 // Logs a histogram for the JumplistCategory of the item that was clicked. 26 // Logs a histogram for the JumplistCategory of the item that was clicked.
28 void LogJumplistActionFromSwitchValue(const std::string& value); 27 void LogJumplistActionFromSwitchValue(const std::string& value);
29 28
30 } // namespace jumplist 29 } // namespace jumplist
31 30
32 #endif // CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_ 31 #endif // CHROME_BROWSER_METRICS_JUMPLIST_METRICS_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698