Adding using protobuf based communication for the power information transfer.

Adding using protobuf based communication for the power information transfer.

Added in gyp rule for building the needed protobuf. Added secondary code path that calls the PopArrayOfBytesAsProto command and then passes the value up to the rest of Chrome. Removed the old code path.

BUG=chromium-os:25489
TEST=Build image using new code path ChromeOS and Chrome.      Then test that is
     working on a device.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125005

[rharrison, 2012-01-31 21:21:50]

I am intending to build a test image tomorrow for the purposes of verifying that
this CL does what is desired in combination with the ChromeOS change.

[rharrison, 2012-02-07 20:13:54]

I have cleaned up the CLs leading up to this one and I am in the process of
landing them, so could you please review this.

[satorux1, 2012-02-07 21:16:49]

http://codereview.chromium.org/9318007/diff/4001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/power_manager_client.cc (right):

http://codereview.chromium.org/9318007/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/power_manager_client.cc:171: dbus::MethodCall
get_all_method_call(power_manager::kPowerManagerInterface,
Do we still need to call the older method? I thought this one was replaced with
the protobuf version.

http://codereview.chromium.org/9318007/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/power_manager_client.cc:172:
power_manager::kGetAllPropertiesMethod);
nit: please align parameters vertically:

dbus::MethodCall get_all_method_call(
    power_manager::kPowerManagerInterface,
    power_manager::kGetAllPropertiesMethod);

http://codereview.chromium.org/9318007/diff/4001/dbus/message.h
File dbus/message.h (right):

http://codereview.chromium.org/9318007/diff/4001/dbus/message.h#newcode14
dbus/message.h:14: #include
"third_party/protobuf/src/google/protobuf/message_lite.h"
I guess it was added here by accident, rigth?

[satorux1, 2012-02-13 20:18:34]

ping?

[rharrison, 2012-02-13 20:54:38]

On 2012/02/13 20:18:34, satorux1 wrote:
> ping?

I was dealing with other CLs that this depends on so did not get a chance to
address this last week. I agree that this CL should remove the old code path.

I am out of the office this week, so if I get the chance I will upload a patch
with that change,but it is likely to be delayed until next week.

[satorux1, 2012-02-13 21:03:55]

Thanks you for the update. sounds good to me.

[rharrison, 2012-02-14 17:03:08]

I have removed the old code path from the build now. I don't have an easy way to
test this change at the moment. I will ping someone in Waterloo to test it for
me.

http://codereview.chromium.org/9318007/diff/4001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/power_manager_client.cc (right):

http://codereview.chromium.org/9318007/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/power_manager_client.cc:171: dbus::MethodCall
get_all_method_call(power_manager::kPowerManagerInterface,
On 2012/02/07 21:16:49, satorux1 wrote:
> Do we still need to call the older method? I thought this one was replaced
with
> the protobuf version.

Done.

http://codereview.chromium.org/9318007/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/power_manager_client.cc:172:
power_manager::kGetAllPropertiesMethod);
On 2012/02/07 21:16:49, satorux1 wrote:
> nit: please align parameters vertically:
> 
> dbus::MethodCall get_all_method_call(
>     power_manager::kPowerManagerInterface,
>     power_manager::kGetAllPropertiesMethod);

Done.

http://codereview.chromium.org/9318007/diff/4001/dbus/message.h
File dbus/message.h (right):

http://codereview.chromium.org/9318007/diff/4001/dbus/message.h#newcode14
dbus/message.h:14: #include
"third_party/protobuf/src/google/protobuf/message_lite.h"
On 2012/02/07 21:16:49, satorux1 wrote:
> I guess it was added here by accident, rigth?

Done.

[satorux1, 2012-02-14 17:11:41]

LGTM. There is no rush. Please check this in once you get back to work.

[rharrison, 2012-02-14 19:55:11]

On 2012/02/14 17:11:41, satorux1 wrote:
> LGTM. There is no rush. Please check this in once you get back to work.

cwolfe tested this CL for me and it is throwing errors when running. obviously I
am not submitting this at this time. I will investigate this when I return to
the office next week and have more cycles to dedicate to it.

[rharrison, 2012-03-01 21:22:40]

On 2012/02/14 19:55:11, rharrison wrote:
> On 2012/02/14 17:11:41, satorux1 wrote:
> > LGTM. There is no rush. Please check this in once you get back to work.
> 
> cwolfe tested this CL for me and it is throwing errors when running. obviously
I
> am not submitting this at this time. I will investigate this when I return to
> the office next week and have more cycles to dedicate to it.

After investigation I have determined that the issue that cwolfe and I were
seeing was due to a bug in powerd. I have tested that this CL works as expected
with the fix in place. Once the fix for powerd lands I will land this.

[commit-bot: I haz the power, 2012-03-02 16:27:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/9318007/18001

[commit-bot: I haz the power, 2012-03-02 16:58:43]

Try job failure for 9318007-18001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-03-05 19:57:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/9318007/27001

[commit-bot: I haz the power, 2012-03-05 21:53:23]

Change committed as 125005